New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Publish typings on travis publish #1517
Conversation
@sapegin do you want me to add a cookbook item for the usage of the types in components? |
Thanks! Yep, a cookbook entry would be nice. |
The cookbook has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few edits, otherwise looks good.
docs/Cookbook.md
Outdated
|
||
It allows the maintainers to catch type mismatch before execution and a better developer experience. | ||
|
||
It also allows users to write their customized styleguide components using typescript TSX and plugins to build it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also allows users to write their customized styleguide components using typescript TSX and plugins to build it. | |
It also allows users to write their customized style guide components using TypeScript and plugins to build it. |
What plugins do you mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to leverage the type checking powers of typescript and its red squigglies to help you code.
Plugins would be vscode type checking, or Sublime Text or Atom TS plugin.
I think I can omit it as it is self explanatory.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that's quite confusing for me ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it.
Co-Authored-By: Artem Sapegin <artem@sapegin.ru>
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As previously mentioned, I want to be able to use the types generated by rsg in vue-styleguidist.
This publishes the types with the compiled library.
There is a known limitation:
rsg-component
aliased path have to be kept in thetsconfig.json
of any project using the types. It should redirect tonode_modules/react-styleguidist/lib/client/rsg-component
.