Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove remnants of Flow #1549

Merged
merged 8 commits into from Mar 10, 2020
Merged

Chore: Remove remnants of Flow #1549

merged 8 commits into from Mar 10, 2020

Conversation

sapegin
Copy link
Member

@sapegin sapegin commented Mar 7, 2020

Remove pieces of Flow left after the TypeScript migration.

@sapegin sapegin requested a review from elevatebart March 7, 2020 17:28
@lgtm-com
Copy link

lgtm-com bot commented Mar 7, 2020

This pull request fixes 1 alert when merging 20a8dd2 into 847f917 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@elevatebart
Copy link
Collaborator

I believe we have to keep @babel/preset-flow for some tests.
Apart from that and the small alert, I see no pb with this one.

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2020

This pull request fixes 1 alert when merging 8285bd5 into 3bd566b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Collaborator

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added two changes, please check them out

  • add back flow preset for Props.spec.tsx
  • make index.ts export a default object to avoid mistakes (potential breaking change)

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2020

This pull request fixes 1 alert when merging 283b329 into 3bd566b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #1549 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
babel.config.js 100.00% <ø> (ø)
src/loaders/utils/client/evalInContext.ts 100.00% <ø> (ø)
src/loaders/utils/client/requireInRuntime.ts 100.00% <ø> (ø)
src/scripts/index.esm.ts 100.00% <100.00%> (ø)

@sapegin
Copy link
Member Author

sapegin commented Mar 8, 2020

We'll need to updates the docs then: https://react-styleguidist.js.org/docs/api.html

@elevatebart
Copy link
Collaborator

elevatebart commented Mar 8, 2020 via email

@elevatebart
Copy link
Collaborator

I updated the documentation using imports instead of requires. I hope you find it useful.
It might be useful to add a note about NodeJs not accepting es6 imports. There is a non obvious need for transpilation.

@lgtm-com
Copy link

lgtm-com bot commented Mar 9, 2020

This pull request fixes 1 alert when merging 0dd7c84 into 106df96 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sapegin
Copy link
Member Author

sapegin commented Mar 9, 2020

I think we can also reexport it as CommonJS in a separate module to avoid breaking changes.

@elevatebart
Copy link
Collaborator

I did my best. I hope you like it.

@lgtm-com
Copy link

lgtm-com bot commented Mar 9, 2020

This pull request fixes 1 alert when merging 59e97ef into 106df96 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sapegin
Copy link
Member Author

sapegin commented Mar 10, 2020

I'm not sure the module field is useful here, I think it's only used by bundlers, but good enough for now ;-) Thanks for the changes!

@sapegin sapegin merged commit b0d334a into master Mar 10, 2020
@sapegin sapegin deleted the noflow branch March 10, 2020 07:55
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants