New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove remnants of Flow #1549
Conversation
This pull request fixes 1 alert when merging 20a8dd2 into 847f917 - view on LGTM.com fixed alerts:
|
I believe we have to keep |
This pull request fixes 1 alert when merging 8285bd5 into 3bd566b - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added two changes, please check them out
- add back flow preset for Props.spec.tsx
- make index.ts export a default object to avoid mistakes (potential breaking change)
This pull request fixes 1 alert when merging 283b329 into 3bd566b - view on LGTM.com fixed alerts:
|
Codecov Report
|
We'll need to updates the docs then: https://react-styleguidist.js.org/docs/api.html |
I agree, I will take care of it before tomorrow.
Bart Ledoux
Join me on LinkedIn
Or as @elevatebart on Discord, Twitter and Github
…On Mar 8, 2020, 16:08 -0500, Artem Sapegin ***@***.***>, wrote:
We'll need to updates the docs then: https://react-styleguidist.js.org/docs/api.html
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I updated the documentation using imports instead of requires. I hope you find it useful. |
This pull request fixes 1 alert when merging 0dd7c84 into 106df96 - view on LGTM.com fixed alerts:
|
I think we can also reexport it as CommonJS in a separate module to avoid breaking changes. |
I did my best. I hope you like it. |
This pull request fixes 1 alert when merging 59e97ef into 106df96 - view on LGTM.com fixed alerts:
|
I'm not sure the |
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Remove pieces of Flow left after the TypeScript migration.