-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not work with Webpack 2.1.0-beta.23+ #184
Comments
webpack.LoaderOptionsPlugin doesn’t work for some reason.
2.1.0-beta.24 is out with nicer validation warnings:
But what it suggests doesn’t work for some reason. |
I suggest drop webpack2 support for a while. Now latest styleguidist breaks my builds. |
@nkt Which version breaks your build? What errors you see? Users already have a chose: they can use Webpack 1 or 2. |
Nope. latest webpack haven't marked as beta relase, so npm installs it instead of webpack 1 |
@nkt Then you need to file a bug for Webpack. It is beta. |
Dependencies of this project requires |
Ah, ok. I'm using npm@3, so I can specify webpack version in my package.json. But you should to know, all users with latest |
Thanks for fast answers! |
Probably we should make it a peerDependency since npm installs the latest by default. Thanks for the investigation! |
@sapegin ensure you have Also make sure you're getting options the right way: https://github.com/wbuchwalter/tslint-loader/blob/e022cc8bbff5a69ec594716af03c0692c81920df/index.js |
@aaronjensen I don’t understand what should be in new webpack.LoaderOptionsPlugin({
test: /styleguide/,
options: {
styleguidist: config,
},
}), and this new webpack.LoaderOptionsPlugin({
options: {
context: __dirname,
styleguidist: config,
},
}), In both cases |
@sokra could you comment on this? Why would |
One thing that might be different from common loaders is how we use them: let { config, components, sections } = require('styleguide!');
require('!!props!file.js')
require('examples!Readme.md') |
Looks like |
Or maybe @TheLarkInn can help us? 🙏 |
|
@TheLarkInn I’ve tried that too but |
Awesome. It makes me wonder if a |
btw, now that it's working could you cut a new release so we can upgrade please? Thanks! |
@aaronjensen I’ll do it in the next few days. There are quite a lot of changes and I want to finish a few more things ;-) |
@aaronjensen I’ve added a Roadmap, and 4.0 is very close ;-) |
Webpack has introduced a config validation in beta23 which breaks our build:
Not sure how we can make a config that works in Webpack 1 and 2.
https://github.com/webpack/webpack/releases/tag/v2.1.0-beta.23
The text was updated successfully, but these errors were encountered: