Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for absolute imports #658

Closed
zerocity opened this issue Oct 31, 2017 · 2 comments
Closed

Support for absolute imports #658

zerocity opened this issue Oct 31, 2017 · 2 comments
Labels
help wanted

Comments

@zerocity
Copy link

Hi,

on create react app they have a discussion about supporting absolut imports via nested node_modules folder (src/node_modules).

With the current version (6.0.32) of Styleguidist the components are getting render but no changes to the source are recognise of the webDevServer in this folder.

If i change the value to
^(?!.*([/\\\\]src[/\\\\]node_modules[/\\\\])).*([/\\\\]node_modules[/\\\\])
the changes are recognise in src/node_modules. (other solution )

I need the possibility to overwrite the ignore property or have a better default.
zerocity pushed a commit to 25th-floor/ttrack-client that referenced this issue Oct 31, 2017
Add react-styleguidist
858d628 
- uses fork for abs path support (styleguidist/react-styleguidist#658)
- disable example components
- sort package.json
@sapegin
Copy link
Member

sapegin commented Nov 6, 2017

I’ll be happy to merge a pull request with this feature.

@sapegin
Copy link
Member

sapegin commented Nov 24, 2017

It should be possible now — #690.

@sapegin sapegin closed this as completed Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zerocity @sapegin