Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding default webpack dev server options #690

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Allow overriding default webpack dev server options #690

merged 3 commits into from
Nov 16, 2017

Conversation

jure
Copy link
Contributor

@jure jure commented Nov 15, 2017

There is currently no way to override webpack dev server options. For example, we specifically want the dev server to look at node_modules/ too (to develop using linked dependencies) and there isn't a way to do that.

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, make sense!

Probably we should still force contentBase.

@sapegin sapegin added this to the 6.1.0 milestone Nov 15, 2017
@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
scripts/create-server.js 92.3% <100%> (ø) ⬆️

@jure
Copy link
Contributor Author

jure commented Nov 16, 2017

@sapegin I had a solution where I'd just play with the order of things in the merge(), but this seems more readable and explicit.

@sapegin
Copy link
Member

sapegin commented Nov 16, 2017

I’d actually add it to merge as the last argument — would be more readable and consistent.

@jure
Copy link
Contributor Author

jure commented Nov 16, 2017

Yeah, that's what I had, personally found the override a bit too implicit then. I'll do it, though, sure.

@sapegin sapegin merged commit 1def29d into styleguidist:master Nov 16, 2017
@sapegin
Copy link
Member

sapegin commented Nov 16, 2017

Thanks, merged!

This was referenced Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants