Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathLine config supported for section #1166

Closed

Conversation

benwiley4000
Copy link

@benwiley4000 benwiley4000 commented Oct 8, 2018

This is useful for me because it allows me to use sections to document library exports that aren't React components, and still get the pathline feature that you get with generated React component docs.

Example:
screenshot from 2018-10-07 23-11-13

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #1166 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted Files Coverage Δ
src/rsg-components/Section/Section.js 100% <ø> (ø) ⬆️
loaders/utils/getSections.js 100% <ø> (ø) ⬆️
src/rsg-components/Section/SectionRenderer.js 90% <50%> (-10%) ⬇️

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

And please add some tests.

@@ -115,6 +115,7 @@ Each section consists of (all fields are optional):
- `ignore` — string/array of globs that should not be included in the section.
- `href` - an URL to navigate to instead of navigating to the section content
- `external` - if set, the link will open in a new window
- `pathLine` - if the section is associated with a particular source file, this can be passed to display a copy-able filepath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really explain how it works. Something like this may be better:

Text to show with a copy to clipboard button below the heading, similar to component’s pathlines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool sounds good!

@stale
Copy link

stale bot commented Jan 6, 2019

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Jan 6, 2019
@stale stale bot closed this Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants