Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up webpack, dev-server, merge, eslint-plugin-compat, react-dev-utils add webpack to peer #1180

Closed

Conversation

AndreyGladkov
Copy link

yarn install shows warnings

warning " > webpack-dev-server@2.11.3" has incorrect peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "webpack-dev-server > webpack-dev-middleware@1.12.2" has incorrect peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".

Remote Code Execution in react-dev-utils

Add webpack to peerDependencies.

@AndreyGladkov AndreyGladkov mentioned this pull request Oct 17, 2018
4 tasks
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

package.json Outdated
},
"peerDependencies": {
"react": ">=15",
"react-dom": ">=15"
"react-dom": ">=15",
"webpack": ">=4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack isn't in peerDependencies to support tools like Create React App that have their own webpack. We have a version check to be sure that the user has the supported webpack version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the user does not use webpack. he will see install:

warning "react-styleguidist > uglifyjs-webpack-plugin@1.2.7" has unmet peer dependency "webpack@^2.0.0 || ^3.0.0 || ^4.0.0".
warning "react-styleguidist > webpack-dev-server@2.11.3" has unmet peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "react-styleguidist > webpack-dev-server > webpack-dev-middleware@1.12.2" has unmet peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".

if build:

Webpack is required for Styleguidist, please add it to your project:

    npm install --save-dev webpack

See how to configure it for your style guide:
https://react-styleguidist.js.org/docs/webpack.html
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I thought it was true to talk about this dependency when installing.
Ok I will remove from peer.

sapegin pushed a commit that referenced this pull request Oct 23, 2018
## Breaking changes

### Drop webpack 3 support

Webpack 3 is no longer supported, webpack 4 is the minimum required version.

As a side effect you shouldn’t see any webpack warnings when you run Styleguidist.

We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle.

* #1175, #1178 by @derz
* #1165 by @elevatebart
* #1148 by @elevatebart
* #915, #1023 by @stepancar
* #1180 by @AndreyGladkov
@stale
Copy link

stale bot commented Jan 17, 2019

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants