Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Running the customized example results in an error #1445

Merged

Conversation

tonyjmartinez
Copy link
Contributor

I encountered the following error running the customized example.

Screen Shot 2019-10-12 at 8 31 48 PM

Upgrading the packages in package.json fixed that problem. Updating the babel config fixed a problem that the package upgrade introduced with core-js.

@tonyjmartinez tonyjmartinez changed the title Updated package.json and babel config to resolve issue Fix: Running the customized example results in an error Oct 13, 2019
@tonyjmartinez
Copy link
Contributor Author

I found that the same issue was happening in a few of the other examples so I went a similar route. I didn't upgrade in examples where the upgrade introduced a different problem.

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! But please revert indentation changes.

@elevatebart
Copy link
Collaborator

Hey @sapegin,
Would it be a good time to merge this PR?
It would trigger a patch release (that failed in the previous commit since the commit message did not contain Fix: ).

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@sapegin
Copy link
Member

sapegin commented Jan 9, 2020

@elevatebart Yup, looks good now!

@elevatebart elevatebart merged commit 0636382 into styleguidist:master Jan 9, 2020
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 10.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants