Fix:(isolation mode issue) issue #1492 #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
changes regarding the isolated page view url...
|
Hello @sapegin,
|
|
🎉 This PR is included in version 10.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
piyushkadam5
changed the title
This was referenced Apr 7, 2022
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue link: #1492
This issue occurred because of the fix that have been made in version 10.0.1 for the issue: #1454
Hashed Url example: the "#button" in the url is an example of Hashed Url...it gets appended after clicking the Button component in the side-Navbar...
After the issue #1454 was resolved...it was taking the hashed url token in the isolated page(which opens after clicking the fullscreen icon) url as you can see below
after clicking the fullscreen icon we got results like this!
so this was the issue which is resolved by doing a simple check i.e. we are verifying if the currentHash that we are getting in the 'buildIsolatedOrNoChromeFragment()' function is a hashedUrl("#button") or a Section-Url("#/Components")...
we just checked the first character after the '#' in the currentHash string if it matches the hashedUrlpattern then we are neglecting the extra currentHashPath...
now as you can see below we removed the "/button" from the url...it is working fine..
we have written a test case for that as you can check...!
and also the issue mentioned in #1454 is also working fine...