Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 support #1903

Merged
merged 12 commits into from
Jan 27, 2022
Merged

Webpack 5 support #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5361cca
dep(react-dev-util): upgrade to pre-release with Webpack 5 support
juanca Sep 21, 2021
01d3d37
fake release to test branch in other projects running Webpack 5
juanca Sep 21, 2021
1b9b300
dep(webpack): upgrade to latest ^4
juanca Oct 22, 2021
e1fc8f5
fake release to test branch in other projects running Webpack 5
juanca Oct 22, 2021
3215379
fix(example): ensure webpacke example uses a webpack configuration
juanca Oct 22, 2021
d5fae6c
dep(react-dev-utils): upgrade to latest ^12 for Webpack 5 support
juanca Dec 21, 2021
9d5b96c
fix(tests): update snapshot to reflect new webpack 5 config
juanca Dec 21, 2021
e74c085
Revert "fake release to test branch in other projects running Webpack 5"
juanca Dec 21, 2021
9858706
Revert "fake release to test branch in other projects running Webpack 5"
juanca Dec 21, 2021
7d38164
fix(webpack example): reference compiled library instead of a publish…
juanca Jan 14, 2022
11a6a80
refactor(webpack example): remove redundant Webpack configuration sin…
juanca Jan 14, 2022
dee64e9
Merge remote-tracking branch 'upstream/master' into master
juanca Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28,647 changes: 22,071 additions & 6,576 deletions examples/webpack/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"prop-types": "^15.6.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-styleguidist": "^11.1.1",
"react-styleguidist": "file:../../",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change to get the automatic Webpack configuration to work. This means you can run this particular package.json from its directory and it will treat itself as the root directory. This also means it will use the current working compiled code for react styleguidist when running this example. I think that's a better experience for developers because you will want to make changes to the library and test them against a local example. /cc @sapegin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

cd examples/webpack
npm install
npm run build
npm run styleguide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

"style-loader": "^2.0.0",
"webpack": "^5.3.2"
},
Expand Down
Loading