Don't display sidebar and search field if there are no components found #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
reviewed
Nov 20, 2016
| @@ -64,7 +64,7 @@ export default class StyleGuide extends Component { | |||
| components={this.renderComponents(components, sections, sidebar, singleExample)} | |||
| sections={sections} | |||
| toc={this.renderTableOfContents(components, sections)} | |||
| sidebar={sidebar} | |||
| sidebar={!isEmpty(components) || !isEmpty(sections)} | |||
There was a problem hiding this comment.
You need to keep sidebar here too, otherwise it breaks isolated view.
|
Whoops, my bad, I thought it was a boolean. |
|
It is boolean, and it’s false isolated mode ;-) |
|
Right, it can also be false in isolated mode. It's getting late, I should get some sleep... Is the PR ok otherwise? |
|
Yep, thanks! |
sapegin
added a commit
that referenced
this pull request
Nov 22, 2016
## New feature Now style guide should hot reload when you add new components. New config option , by default will watch common root folder for all your components. (#242 by @aaronjensen) ## Bug fixes and other improvements * Don’t show sidebar if there are no components found (#247 by @n1313) * Add mobile styles to improve display on narrow screens (#244 by @n1313) * Add extra HTML markup to make previews easier to find with CSS selectors (#238, #243 by @n1313)
sapegin
added a commit
that referenced
this pull request
Nov 22, 2016
For some reason (most probably after transition to a GitHub organization) Travis CI stopped to check pull requests.
sapegin
added a commit
that referenced
this pull request
Nov 22, 2016
## New feature Now style guide should hot reload when you add new components. New config option , by default will watch common root folder for all your components. (#242 by @aaronjensen) ## Bug fixes and other improvements * Don’t show sidebar if there are no components found (#247 by @n1313) * Add mobile styles to improve display on narrow screens (#244 by @n1313) * Add extra HTML markup to make previews easier to find with CSS selectors (#238, #243 by @n1313)
sapegin
pushed a commit
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a search field on the "no components found" page (can be encountered in
customisedexample before PR #246 It is lonely and somewhat useless, and probably shouldn't be there in the first place.