Add extra HTML markup to make previews easier to find with CSS selectors #243
Conversation
| @@ -3,3 +3,4 @@ examples/**/styleguide/index.html | |||
| .publish/ | |||
| node_modules/ | |||
| Changelog.md | |||
| .DS_Store | |||
There was a problem hiding this comment.
Please you your global gitignore for that.
|
Hmm, okay, that's unusual but I can redo the PR. Is there any harm in having it ignored explicitly and not depending on an implicit undocumented global setting, though? Sent from my iPhone
|
|
It’s well documented and I think it‘s better to configure it once for your system than add to each project separately. You can just revert this commit, I’ll squash everything anyway. |
This reverts commit d753d1d.
|
I understand your point, and I agree that adding .DS_Store to a global ignore is a good idea. Unfortunately it is not a widely adopted approach (I think this is the only repo I know of that does that) and it is not documented anywhere (the decision to depend on a globally ignored .DS_Store, not the idea of having a global gitignore), so I think this kind of clash is bound to happen again, I'm afraid. |
|
I should make a poll in Twitter ;-) For me it happens maybe once in a year and it could be any kind of artifacts of tools developers use on their computers. I wouldn’t expect every project have all these things in their gitignore. |
|
But probably you’re right and it‘s just my perfectionism ;-) I’ve checked a few popular JS projects (React, Redux, Lodash, etc.): all of them have |
|
Well, I leave it to you to decide whether you want to have things like .DS_Store or npm-debug.log in there. I have reverted my .gitignore change. Please review the PR. |
## New feature Now style guide should hot reload when you add new components. New config option , by default will watch common root folder for all your components. (#242 by @aaronjensen) ## Bug fixes and other improvements * Don’t show sidebar if there are no components found (#247 by @n1313) * Add mobile styles to improve display on narrow screens (#244 by @n1313) * Add extra HTML markup to make previews easier to find with CSS selectors (#238, #243 by @n1313)
## New feature Now style guide should hot reload when you add new components. New config option , by default will watch common root folder for all your components. (#242 by @aaronjensen) ## Bug fixes and other improvements * Don’t show sidebar if there are no components found (#247 by @n1313) * Add mobile styles to improve display on narrow screens (#244 by @n1313) * Add extra HTML markup to make previews easier to find with CSS selectors (#238, #243 by @n1313)
Fixes #238