Issue #774: Adding support to location array #843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
requested changes
Feb 26, 2018
loaders/utils/getComponentFiles.js
Outdated
| @@ -21,6 +22,8 @@ module.exports = function getComponentFiles(components, rootDir, ignore) { | |||
| let componentFiles; | |||
| if (isFunction(components)) { | |||
| componentFiles = components(); | |||
| } else if (isArray(components)) { | |||
scripts/__tests__/config.spec.js
Outdated
| @@ -35,12 +36,36 @@ it('should accept config as an object', () => { | |||
| expect(result).toMatchObject({ title: 'Style guide' }); | |||
| }); | |||
|
|
|||
| it('should accept components as a string', () => { | |||
There was a problem hiding this comment.
These tests don’t add much (if any) value: you’re testing this line:
type: ['string', 'function', 'array'],
which is already tested in config sanitizer tests.
| @@ -94,6 +94,34 @@ it('should return correct component paths: function returning absolute paths', ( | |||
| expect(result).not.toMatch(`'filepath': 'components/RandomButton/RandomButton.js'`); | |||
| }); | |||
|
|
|||
| it('should return correct component paths: function returning absolute paths', () => { | |||
There was a problem hiding this comment.
function returning absolute paths → array of component absolute paths.
You can also add a test for relative paths.
|
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is my first time contributing, so let me know if I've done it correctly and how can I help with other issues. I've committed some changes to ./loades/utils/getComponentFiles.js, but not sure how to test it properly so codecov decreased a little. Can I follow the same pattern in styleguideloader.spec.js to get this part covered?
Thanks!