Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump husky from 5.1.3 to 6.0.0 #175

Merged
merged 1 commit into from Apr 2, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2021

Bumps husky from 5.1.3 to 6.0.0.

Release notes

Sourced from husky's releases.

v6.0.0

After being in early access for Open Source projects and Sponsors for a limited time, I'm happy to announce that husky 6 is MIT again and can be freely used in commercial projects! 馃帀

Many thanks to the Open Source projects and Companies which have switched to/sponsored the new husky during this period!

OSS is my full-time job, please consider sponsoring the development of husky on GitHub sponsors or Open Collective. Thank you!

Breaking change

  • husky init has been moved to its own package (npx husky-init)

Added

  • Programmatically use husky: require('husky')
  • TypeScript definitions

Migrating from husky 4

Husky 6 contains breaking changes. If you're coming from v4, npm install husky@6 won't be enough.

Recommended: see husky-4-to-6 CLI to automatically migrate your config. There's also a dedicated section in the docs.

If you're curious why config has changed, you may be interested in reading: https://blog.typicode.com/husky-git-hooks-javascript-config/

Also Husky 6 follows official npm and Yarn best practices regarding autoinstall. It's recommended to use prepare script instead (see usage in docs).

v5.2.0

  • Add set command to replace hooks (husky set .husky/pre-commit cmd)
  • Update add command to append command (husky add .husky/pre-commit cmd)
  • Improve error messages
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [husky](https://github.com/typicode/husky) from 5.1.3 to 6.0.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v5.1.3...v6.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the pr: dependencies relates to dependencies label Apr 1, 2021
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog-wise it seems like this breaking change doesn't affect us, since we've already initialized husky v5 in this repo. I also tested locally with some dummy changes and the hook still fires, so I think this is good to merge!

@mattxwang mattxwang merged commit de31cfe into master Apr 2, 2021
@mattxwang mattxwang deleted the dependabot/npm_and_yarn/husky-6.0.0 branch April 2, 2021 23:28
@ybiquitous
Copy link
Member

@mattxwang Thanks for the merge!

Do we need is-ci and pinst still? It seems needless to me when reading the husky doc. 馃

"prepare": "is-ci || husky install",

"prepublishOnly": "pinst --disable",
"postpublish": "pinst --enable",

@mattxwang
Copy link
Member

Great point, and I remember you fixing the config to address this on the main repo. I can get around to resolving this!

@mattxwang mattxwang mentioned this pull request Apr 11, 2021
@mattxwang
Copy link
Member

Made a PR in #177 to follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Development

Successfully merging this pull request may close these issues.

None yet

2 participants