-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exact versions for devDependencies #12
Comments
I'm all on board with using carets for |
Again, I think we should encourage semver, not be afraid of it. And if some package break "all the times" by minor, maybe we should just stop using them :) |
Currently, I am pretty confident that babel, eslint and tape follow semver correctly. |
You have strong feelings so we should just go with them. |
Haha. If we got issues in the future, we might reconsider this. |
Yep, that's what I figure. If we have no problems, then everything's fine! |
## The dependency [leven](https://github.com/sindresorhus/leven) was updated from `2.1.0` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v3.0.0</summary> <p>Breaking:</p> <ul> <li>Require Node.js 6 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="419602561" data-permission-text="Issue title is private" data-url="sindresorhus/leven#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/leven/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/pull/12">#12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/leven/commit/3eb8c04c42c763be76f713965c2847443f365aa8/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/commit/3eb8c04c42c763be76f713965c2847443f365aa8"><tt>3eb8c04</tt></a></li> </ul> <p>Enhancements:</p> <ul> <li>Improve performance (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="228838401" data-permission-text="Issue title is private" data-url="sindresorhus/leven#10" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/leven/pull/10/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/pull/10">#10</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/leven/commit/37573fe34466202f0f2cdbf04cefe5d1968eed88/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/commit/37573fe34466202f0f2cdbf04cefe5d1968eed88"><tt>37573fe</tt></a></li> <li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="419602561" data-permission-text="Issue title is private" data-url="sindresorhus/leven#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/leven/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/pull/12">#12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/leven/commit/3eb8c04c42c763be76f713965c2847443f365aa8/hovercard" href="https://urls.greenkeeper.io/sindresorhus/leven/commit/3eb8c04c42c763be76f713965c2847443f365aa8"><tt>3eb8c04</tt></a></li> </ul> <p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/leven/compare/v2.1.0...v3.0.0"><tt>v2.1.0...v3.0.0</tt></a></p> </details> <details> <summary>Commits</summary> <p>The new version differs by 4 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/sindresorhus/leven/commit/254cdab92b2a3154dfb219ec0fcaa9645096e0f1"><code>254cdab</code></a> <code>3.0.0</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/leven/commit/06fda13f82dd3b86581f6815fa6e6a0b8cbed733"><code>06fda13</code></a> <code>Add a more realistic benchmark fixture</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/leven/commit/3eb8c04c42c763be76f713965c2847443f365aa8"><code>3eb8c04</code></a> <code>Require Node.js 6, add TypeScript definition (#12)</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/leven/commit/37573fe34466202f0f2cdbf04cefe5d1968eed88"><code>37573fe</code></a> <code>Remove unnecessary length checks + improved indexing of charCodeCache (#10)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/sindresorhus/leven/compare/0630566a69b5a73aae2e52bb47ea863892a4b5f0...254cdab92b2a3154dfb219ec0fcaa9645096e0f1">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
## The dependency [resolve-from](https://github.com/sindresorhus/resolve-from) was updated from `4.0.0` to `5.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v5.0.0</summary> <p>Breaking:</p> <ul> <li>Require Node.js 8 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432880928" data-permission-text="Issue title is private" data-url="sindresorhus/resolve-from#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/resolve-from/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/pull/12">#12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf"><tt>188ed7d</tt></a></li> <li>Return <code>undefined</code> instead of <code>null</code> when the module cannot be found (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432880928" data-permission-text="Issue title is private" data-url="sindresorhus/resolve-from#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/resolve-from/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/pull/12">#12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf"><tt>188ed7d</tt></a></li> </ul> <p>Enhancements:</p> <ul> <li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432880928" data-permission-text="Issue title is private" data-url="sindresorhus/resolve-from#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/resolve-from/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/pull/12">#12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf/hovercard" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf"><tt>188ed7d</tt></a></li> </ul> <p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/resolve-from/compare/v4.0.0...v5.0.0"><tt>v4.0.0...v5.0.0</tt></a></p> </details> <details> <summary>Commits</summary> <p>The new version differs by 2 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/sindresorhus/resolve-from/commit/53f4a1b40f972dbfc4dda9627d24068000eae897"><code>53f4a1b</code></a> <code>5.0.0</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/resolve-from/commit/188ed7da119c788d98272852e8a71fd19195f6cf"><code>188ed7d</code></a> <code>Require Node.js 8, return <code>undefined</code> instead of <code>null</code>, add TypeScript definition (#12)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/sindresorhus/resolve-from/compare/60cd04e69135b96b98b848fff719b1276a5610c0...53f4a1b40f972dbfc4dda9627d24068000eae897">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
What would you think about using exact versions for
devDependencies
?I have seen and run into problems with CI when using carets for these (CI installs later version than you have locally, that version was improperly versioned so has some breaking change, etc.); and at the same time I don't know of any advantage to using the caret for devDependencies, since people will only install them for development so we don't have to worry about overcomplicated the dependency tree. Seems to me clearer and less error prone to be exact. Thoughts?
The text was updated successfully, but these errors were encountered: