Update micromatch #3769
Merged
Update micromatch #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😆 |
jeddy3
approved these changes
Nov 1, 2018
alexander-akait
approved these changes
Nov 1, 2018
So funny 🤣 Thanks a bunch @hudochenkov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behold! It's serious this time.
It's been almost a year and a half since last major micromatch version released #2597. Finally, I had time and possibility to tackle this thing. And the solution is so simple — convert all patterns from Windows to Unix paths.
augmentConfig.jsconverts all patterns to patterns with absolute paths, and new micromatch supports only Unix paths in patterns.Also, allow Appveyor to run all tests.
Supersedes #2888.