-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-empty-first-line rule #3650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bilie Looking good, thanks.
I've made two minor requests. Can you also add the rule the the example config, please?
(Putting this as comment, rather than an explicit request as I'm off on holiday and I don't want to block this being merged if others are able to review).
a { color: pink; } | ||
``` | ||
|
||
Completely empty files are not considered violations. These are handled by the rule [no-empty-source](../no-empty-source/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following is more in line with the language in other rule READMEs (and sources aren't always files):
This rule ignores empty sources. Use the [`no-empty-source`](../no-empty-source/README.md) rule to disallow these.
Thank you very much for reviewing my PR! Enjoy your vacation!! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Closes #3536
No, it's self explanatory.