New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-empty-first-line rule #3650

Merged
merged 4 commits into from Sep 24, 2018

Conversation

3 participants
@Bilie
Contributor

Bilie commented Sep 10, 2018

Closes #3536

No, it's self explanatory.

@jeddy3

@Bilie Looking good, thanks.

I've made two minor requests. Can you also add the rule the the example config, please?

(Putting this as comment, rather than an explicit request as I'm off on holiday and I don't want to block this being merged if others are able to review).

a { color: pink; }
```
Completely empty files are not considered violations. These are handled by the rule [no-empty-source](../no-empty-source/README.md).

This comment has been minimized.

@jeddy3

jeddy3 Sep 13, 2018

Member

I think the following is more in line with the language in other rule READMEs (and sources aren't always files):

This rule ignores empty sources. Use the [`no-empty-source`](../no-empty-source/README.md) rule to disallow these.
Show resolved Hide resolved lib/rules/no-empty-first-line/__tests__/index.js
@Bilie

This comment has been minimized.

Contributor

Bilie commented Sep 14, 2018

Thank you very much for reviewing my PR! Enjoy your vacation!! :)

@jeddy3

jeddy3 approved these changes Sep 24, 2018

LGTM, thanks!

@jeddy3 jeddy3 merged commit 7a18014 into stylelint:master Sep 24, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 96.357%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 24, 2018

  • Added: no-empty-first-line rule (#3650).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment