Add no-empty-first-line rule #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
reviewed
Sep 13, 2018
There was a problem hiding this comment.
@Bilie Looking good, thanks.
I've made two minor requests. Can you also add the rule the the example config, please?
(Putting this as comment, rather than an explicit request as I'm off on holiday and I don't want to block this being merged if others are able to review).
| a { color: pink; } | ||
| ``` | ||
|
|
||
| Completely empty files are not considered violations. These are handled by the rule [no-empty-source](../no-empty-source/README.md). |
There was a problem hiding this comment.
I think the following is more in line with the language in other rule READMEs (and sources aren't always files):
This rule ignores empty sources. Use the [`no-empty-source`](../no-empty-source/README.md) rule to disallow these.
|
Thank you very much for reviewing my PR! Enjoy your vacation!! :) |
alexander-akait
approved these changes
Sep 24, 2018
|
This was referenced Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3536
No, it's self explanatory.