Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-empty-first-line rule #3650

Merged
merged 4 commits into from
Sep 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/user-guide/example-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ You might want to learn a little about [how rules are named and how they work to
"no-duplicate-at-import-rules": true,
"no-duplicate-selectors": true,
"no-empty-source": true,
"no-empty-first-line": true,
"no-eol-whitespace": true,
"no-extra-semicolons": true,
"no-invalid-double-slash-comments": true,
Expand Down
1 change: 1 addition & 0 deletions docs/user-guide/rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -355,3 +355,4 @@ Here are all the rules within stylelint, grouped first [by category](../../VISIO
- [`max-line-length`](../../lib/rules/max-line-length/README.md): Limit the length of a line.
- [`no-eol-whitespace`](../../lib/rules/no-eol-whitespace/README.md): Disallow end-of-line whitespace (Autofixable).
- [`no-missing-end-of-source-newline`](../../lib/rules/no-missing-end-of-source-newline/README.md): Disallow missing end-of-source newlines (Autofixable).
- [`no-empty-first-line`](../../lib/rules/no-empty-first-line/README.md): Disallow empty first lines. (Autofixable).
1 change: 1 addition & 0 deletions lib/rules/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ module.exports = [
"no-duplicate-at-import-rules",
"no-duplicate-selectors",
"no-empty-source",
"no-empty-first-line",
"no-eol-whitespace",
"no-extra-semicolons",
"no-invalid-double-slash-comments",
Expand Down
31 changes: 31 additions & 0 deletions lib/rules/no-empty-first-line/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# no-empty-first-line

Disallow empty first lines.

```css
\n
/** ↑
* This newline */
a { color: pink; }
```

This rule ignores empty sources. Use the [`no-empty-source`](../no-empty-source/README.md) rule to disallow these.

The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix all of the problems reported by this rule.

## Options

### `true`

The following patterns are considered violations:

```css
\n
a { color: pink; }
```

The following patterns are *not* considered violations:

```css
a { color: pink; }
```
96 changes: 96 additions & 0 deletions lib/rules/no-empty-first-line/__tests__/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
"use strict";

const rule = require("..");
const { messages, ruleName } = rule;

testRule(rule, {
ruleName,
config: [true],
skipBasicChecks: true,
fix: true,

accept: [
{
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
code: ""
},
{
code: " "
},
{
code: "\n"
},
{
code: "\n\n"
},
{
code: ".class {}"
},
{
code: "\t.class {} "
},
{
code: " .class {} "
},
{
code: "/* comment */"
}
],
reject: [
{
code: "\n.class {} \n",
fixed: ".class {} \n",
description: "empty first line",
message: messages.rejected,
line: 1,
column: 1
},
{
code: "\r\n.class {}",
fixed: ".class {}",
description: "empty first line",
message: messages.rejected,
line: 1,
column: 1
},
{
code: "\n/*some comment*/\n",
fixed: "/*some comment*/\n",
description: "empty first line with comment",
message: messages.rejected,
line: 1,
column: 1
},
{
code: "\n/*some comment*/.class {}\na {}\n",
fixed: "/*some comment*/.class {}\na {}\n",
description: "empty first line with comment and css content",
message: messages.rejected,
line: 1,
column: 1
},
{
code: "\r\n\r\n\r\n\r\n.class {}",
fixed: ".class {}",
description: "multiple empty first lines",
message: messages.rejected,
line: 1,
column: 1
},
{
code: " \r\n\r\n\r\n\r\n.class {}",
fixed: ".class {}",
description: "multiple empty first lines with initial whitespace",
message: messages.rejected,
line: 1,
column: 1
},
{
code: " \n.class {}",
fixed: ".class {}",
description: "empty first line with multiple initial whitespaces",
message: messages.rejected,
line: 1,
column: 1
}
]
});
51 changes: 51 additions & 0 deletions lib/rules/no-empty-first-line/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
"use strict";

const eachRoot = require("../../utils/eachRoot");
const report = require("../../utils/report");
const ruleMessages = require("../../utils/ruleMessages");
const validateOptions = require("../../utils/validateOptions");

const ruleName = "no-empty-first-line";

const messages = ruleMessages(ruleName, {
rejected: "Unexpected empty line"
});

const rule = function(actual, _, context) {
return (root, result) => {
const validOptions = validateOptions(result, ruleName, { actual });
if (!validOptions) {
return;
}

eachRoot(root, function(root) {
if (root.source.inline || root.source.lang === "object-literal") {
return;
}
const rootString = root.source.input.css;
if (rootString.trim() === "") {
return;
}

const noEmptyFirstLineTest = RegExp(/^(\s*\r?\n)+/g);

if (noEmptyFirstLineTest.test(rootString)) {
if (context.fix) {
root.nodes[0].raws.before = "";
return;
}

report({
message: messages.rejected,
node: root,
result,
ruleName
});
}
});
};
};

rule.ruleName = ruleName;
rule.messages = messages;
module.exports = rule;