Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate package-lock.json #4517

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Regenerate package-lock.json #4517

merged 1 commit into from
Jan 9, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 7, 2020

This brings package.json and package-lock.json versions up to date.

Do note that due to the way dependabot works, regenerating the lock file is needed after some time, otherwise the deps tree isn't flattened as much as it could be.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 7, 2020

Not sure how to proceed with the jest/valid-describe. We'll hit this later anyway. Should I globally disable the rule?

@hudochenkov
Copy link
Member

Disable it with disable comments in a file.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 7, 2020

Might make more sense to first merge #4504

@ybiquitous
Copy link
Member

@XhmikosR will you rebase #4504?

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 9, 2020

Sure thing, but let's run dependabot one more time before that.

@XhmikosR XhmikosR added the status: wip is being worked on by someone label Jan 9, 2020
@XhmikosR XhmikosR added the pr: blocked is blocked by another issue or pr label Jan 9, 2020
@XhmikosR XhmikosR removed pr: blocked is blocked by another issue or pr status: wip is being worked on by someone labels Jan 9, 2020
"node/no-unsupported-features/node-builtins": ["error", {
"version": ">=10.18.0"
}]
"node/no-unsupported-features/es-builtins": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hudochenkov these changes are done automatically by npm

@hudochenkov hudochenkov merged commit 1dc203e into master Jan 9, 2020
@hudochenkov hudochenkov deleted the master-xmr-deps branch January 9, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants