-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump meow from 5.0.0 to 6.0.0 #4504
Conversation
Bumps [meow](https://github.com/sindresorhus/meow) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/sindresorhus/meow/releases) - [Commits](sindresorhus/meow@v5.0.0...v6.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
I tried restarting the failed Coveralls Job, same result:
There is an old issue noting the same at lemurheavy/coveralls-public#1096 I've restarted to CI again, 500 error seems to me a Coveralls issue... |
I've added a comment to this issue that appears to be what we're seeing |
Coveralls have resolved the issue |
@stylelint/contributors does anyone have time to review this, please? |
When I try it, the following compile error occurs:
diff --git a/lib/cli.js b/lib/cli.js
index 250380a2..b91951a0 100644
--- a/lib/cli.js
+++ b/lib/cli.js
@@ -319,9 +319,7 @@ const meowOptions = {
module.exports = (argv) => {
meowOptions.argv = argv;
/** @type {CLIOptions} */
- const cli =
- // @ts-ignore TODO TYPES
- meow(meowOptions);
+ const cli = meow(meowOptions);
const invalidOptionsMessage = checkInvalidCLIOptions(meowOptions.flags, cli.flags);
diff --git a/package.json b/package.json
index 9529bb5c..8442e660 100644
--- a/package.json
+++ b/package.json
@@ -98,7 +98,6 @@
"@types/global-modules": "^2.0.0",
"@types/globjoin": "^0.1.0",
"@types/lodash": "^4.14.149",
- "@types/meow": "^5.0.0",
"@types/micromatch": "^3.1.1",
"benchmark": "^2.1.4",
"common-tags": "^1.8.0", |
We can use the Lines 293 to 295 in 1c4d6d4
|
What we should do for better type checking of
'max-warnings': {
alias: 'mw',
+ type: 'number',
},
-'max-warnings': {
+maxWarnings: {
alias: 'mw',
+ type: 'number',
},
-const cli = meow(meowOptions);
+const cli = meow({
flags: { ... },
}); However, these tasks will produce many diffs, so I don't know we should do them on this PR (it may be better to do it on another PR?). |
Let's merge this one, and then you'll create a new one with your findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Looks good 👍
Is there a duplicate issue? Otherwise, I will create a new issue about #4504 (comment) |
You could just send a PR without opening an issue. |
OK. Good 👍 |
meow v6 has own built-in type definitions. See <#4504 (comment)>
meow v6 has own built-in type definitions. See <#4504 (comment)>
This aims to prepare for type-checking `cli.js` and does NOT type-check actually. - Camelize option names for type-checking. - Add missing `type` for some options. - Sort options alphabetically for readability. - Add a unit test for the definition (A system test is too much for this purpose). See <#4504 (comment)> for details.
* Refactor CLI options definition This aims to prepare for type-checking `cli.js` and does NOT type-check actually. - Camelize option names for type-checking. - Add missing `type` for some options. - Sort options alphabetically for readability. - Add a unit test for the definition (A system test is too much for this purpose). See <#4504 (comment)> for details.
Bumps meow from 5.0.0 to 6.0.0.
Release notes
Sourced from meow's releases.
Commits
5975fe6
6.0.03e05a2e
Add type information for flags (#122)499d186
Update dependencies5ef9478
Add support fornumber
flag type (#103)8e5248e
Fix typo (#121)cd29865
Only consider enabling autoHelp/autoVersion in case there is only one argumen...54e1f22
Tidelift tasks47fe20f
Create funding.yml927e6e8
Add Node.js 12 to testing (#118)167d1ec
Update dependencies, refactor TypeScript definition to CommonJS compatible ex...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: