Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded @types/meow package #4523

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Remove unneeded @types/meow package #4523

merged 1 commit into from
Jan 9, 2020

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jan 9, 2020 •
edited

meow v6 has own built-in type definitions.
See #4504 (comment)

Blocked by #4517

@ybiquitous
Remove unneeded @types/meow package
041c411 
meow v6 has own built-in type definitions.
See <#4504 (comment)>
@ybiquitous ybiquitous added the pr: blocked is blocked by another issue or pr label Jan 9, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jan 9, 2020

Just go ahead and merge any deps PRs. I also triggered dependabot, so #4517 should be the last to merge after a rebase.

@ybiquitous ybiquitous removed the pr: blocked is blocked by another issue or pr label Jan 9, 2020
@ybiquitous ybiquitous marked this pull request as ready for review January 9, 2020 08:25
@ybiquitous
Copy link
Member Author

@XhmikosR Thanks for your advice!

@XhmikosR XhmikosR added the pr: dependencies relates to dependencies label Jan 9, 2020
XhmikosR
XhmikosR approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to pass so I guess we are OK

@hudochenkov hudochenkov merged commit 74d5233 into master Jan 9, 2020
@hudochenkov hudochenkov deleted the remove-types-meow branch January 9, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@hudochenkov hudochenkov hudochenkov approved these changes

Assignees
No one assigned
Labels
pr: dependencies relates to dependencies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ybiquitous @XhmikosR @hudochenkov