latitude and longitude should be float instead of string.

[zeitnot]

Mongodb gives an exception when set coordinates as string. So they should be set as float. Globally coordinates should be set as float by default.

[vbrazo]

Thanks for contributing 🥇

Your changes look ok. We should rebase before merging.

[zeitnot]

👍

[stephendolan]

This caused a very difficult bug for me to track down in my Rails 5.2 application. I'd like to leave a comment here for any other unfortunate souls who run into an error when upgrading from 1.8.7 -> 1.9.1.

I have a latitude column of type :decimal:

FieldEntry.new.column_for_attribute('latitude')
=> #<ActiveRecord::ConnectionAdapters::PostgreSQLColumn:0x00007fcecb2561f0
 @collation=nil,
 @comment=nil,
 @default=nil,
 @default_function=nil,
 @max_identifier_length=63,
 @name="latitude",
 @null=false,
 @sql_type_metadata=
  #<ActiveRecord::ConnectionAdapters::SqlTypeMetadata:0x00007fcecb256308
   @limit=nil,
   @precision=nil,
   @scale=nil,
   @sql_type="numeric",
   @type=:decimal>,
 @table_name="field_entries">

Note the behavior that this merge request introduces because of the way Rails parses floats vs. strings to a BigDecimal value:

FieldEntry.new(latitude: 29.081408856861657.to_s).latitude
=> 0.29081408856861657e2
FieldEntry.new(latitude: 29.081408856861657.to_f).latitude
=> 0.290814088568617e2

This broke all of the comparisons in my RSpec tests throughout my application because of the incorrect rounding that Rails was doing as a result of getting a float.

The solution was to chain to_s onto my Faker::Address.latitude/longitude calls.

[atomaka]

Echoing @stephendolan, this was difficult to track down and I never guessed Faker was responsible. Perhaps this should be noted in the changelog?