Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spec errors at master branch #381

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Conversation

kakakakakku
Copy link
Contributor

Hi!

I sent my PR (#380), but CI build failed.
Error occured specific versions bellow.

  • Ruby 1.9.2
  • Ruby 1.9.3

I checked error, and I fixed specs.
Maybe #367 is related?

So, I try Ruby 1.9.3 and spec is passed.

  faker git:(fix-spec)  ruby -v
ruby 1.9.3p547 (2014-05-14 revision 45962) [x86_64-darwin13.4.0]

  faker git:(fix-spec)  bundle exec rake test
164 tests, 21922 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

69.17 tests/s, 9246.06 assertions/s

Please review.
Thank you so much.

@kakakakakku
Copy link
Contributor Author

Yeah!
CI build passed by all versions.

@kakakakakku
Copy link
Contributor Author

@stympy and other contributors
How about this PR?
I think this PR is necessary, because specs of master branch is fail.
Thank you so much.

@salexzee
Copy link

+1

1 similar comment
@ghost
Copy link

ghost commented Jul 27, 2015

+1

stympy added a commit that referenced this pull request Jul 27, 2015
Fixed spec errors at master branch
@stympy stympy merged commit 63cefc1 into faker-ruby:master Jul 27, 2015
@kakakakakku
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants