Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rehype #183

Open
nring opened this issue Jun 16, 2022 · 2 comments
Open

Upgrade Rehype #183

nring opened this issue Jun 16, 2022 · 2 comments

Comments

@nring
Copy link
Contributor

nring commented Jun 16, 2022

I noticed an issue when trying to include an inline link in my Ghost Markdown (this is an [inline link](#inline-link)). Ghost sends down the htmlAst properly formatted but the rendered html is improperly formatted. I believe this is an issue to an old version of rehype/rehype-react. There were some significant type changes in the upgraded major versions of each library and I haven't been able to verify that upgrading will indeed fix the problem. However, the new packages add type support for React 18 elements among other things.

@styxlab
Copy link
Owner

styxlab commented Jun 28, 2022

Yes, I noticed the changes in the rehype/rehype-react packages. Unfortunately, they dropped common js support and moved everything to mjs. While the latter is the future, it did not work seamlessly with Next.js. I will revisit this issue, the next time I update the package dependencies.

@nring
Copy link
Contributor Author

nring commented Jun 28, 2022

Sounds good - thank you for taking a look! I actually found the source of the issue I was having, and it's separate from Rehype so I'll open a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants