Turboelectric HTS Ducted Fan Network

[sofie-0]

Pull Request Checklist

• Merge in the latest Develop branch changes to your branch
• Remove .pyc files from your repository:
  • Linux/Mac
    • find . -name *.pyc -delete
  • Windows
    • del /S *.pyc
• Run automatic regression and makes sure everything is passing
• Did you make a new regression test that covers your new code?
• Did you update your docstrings?
• Did you update your headers to include your name and date?
• Do a final compare with the Develop branch to be sure what you're changing

[planes]

Hi, thanks for the PR!

The issue is not with anything any of us did. Looks like there was an error installing some basic python packages way before anything SUAVE related. Here's a stack overflow link where someone had the same problem. I suspect this will be fixed soon.

I tried to restart the build just now and it still errored. Instead of opening and closing the PR, just post a message here in again in a few days and I'll try to rebuild it manually.

In general none of the SUAVE team members will look at a PR until green check mark appears.

[coveralls]

Coverage decreased (-0.03%) to 89.995% when pulling 7fd769d on Sof222:develop into 669b9c7 on suavecode:develop.

[planes]

Hi! Thanks for the PR.

Since you said you are new to using Github, I wanted to let you know what to expect. We'll have a set of reviews, from one or more developers to look over the code until we're satisfied. Then we'll approve your pull request. The automated tools (appeveyor and coveralls) must also approve and we have it set such that we cannot override them.

Just know that if any of our comments seem rude, they're not intended to be. We try to write concise comments. We sometimes leave hundreds of comments in a week.

Please ask us questions if you have any. We are here to help.

[planes]

A couple quick comments. I'll have another set of eyes take a look this week to approve.

Nice work!

[mclarke2]

A few stylistic changes then I will approve. Great work!