Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Docs.rs build fails due to cfg_match! on nightly toolchain #667

Closed
cdata opened this issue Oct 5, 2023 · 3 comments
Closed

Docs.rs build fails due to cfg_match! on nightly toolchain #667

cdata opened this issue Oct 5, 2023 · 3 comments
Assignees
@jsantell
Labels
Bug Incorrect or unexpected behavior Good First Issue Good for newcomers Help Wanted Please lend us your expertise!

Comments

@cdata
Copy link
Collaborator

cdata commented Oct 5, 2023

This might be the sign from the universe that we should be running at least one CI check on the nightly toolchain.

https://docs.rs/crate/noosphere/0.15.1/builds/930119
@cdata cdata added Bug Incorrect or unexpected behavior Help Wanted Please lend us your expertise! Good First Issue Good for newcomers labels Oct 5, 2023
@github-project-automation github-project-automation bot moved this to 🏔️ Icebox in Subconscious + Noosphere Oct 5, 2023
@cdata
Copy link
Collaborator Author

cdata commented Oct 5, 2023

@jsantell FYI

@jsantell
Copy link
Contributor

Upstream bug: getditto/safer_ffi#191
IIRC, there's just one other lifetime change needed, in addition to the above PR, to build noosphere on nightly

@jsantell jsantell moved this from 🏔️ Icebox to 🧑‍🌾 In Progress in Subconscious + Noosphere Oct 19, 2023
@jsantell jsantell self-assigned this Oct 19, 2023
@jsantell
Copy link
Contributor

Fixed via #690

@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsantell jsantell

Labels
Bug Incorrect or unexpected behavior Good First Issue Good for newcomers Help Wanted Please lend us your expertise!
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdata @jsantell