feat: Fix nightly builds and add to CI. #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsantell
force-pushed
the
nightly-build
branch
4 times, most recently
from
f31e4a6
to
66c8888
Compare
jsantell
commented
Oct 20, 2023
jsantell
force-pushed
the
nightly-build
branch
from
66c8888
to
2dff0f9
Compare
jsantell
force-pushed
the
nightly-build
branch
from
2dff0f9
to
de003e4
Compare
|
Upstream getditto/safer_ffi#191 landed in safer_ffi@0.1.4, moving from draft PR |
jsantell
force-pushed
the
nightly-build
branch
4 times, most recently
from
ade2f21
to
a021b4c
Compare
|
rebased on #685, updated with published safer-ffi 0.1.4 containing nightly fix, as well as the removal of a lint rule skip (also fixed in 0.1.4) |
jsantell
force-pushed
the
nightly-build
branch
from
a021b4c
to
6adbe63
Compare
Test flake analysis
Flake summary for
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing with in-flight PR getditto/safer_ffi#191.
There's a new clippy lint rule (documented as available since 1.72.0, though only appears in nightly channels), and some extra finesse on targeting nightly builds with a dynamic lint.also fixed in latest safer_ffiOther than that, just a lifetime change needed.