Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix month days for 2081 Jestha and Ashar #47

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

pabin
Copy link
Contributor

@pabin pabin commented Jun 6, 2023

No description provided.

@pabin pabin closed this Jun 6, 2023
@pabin pabin reopened this Jun 6, 2023
@subeshb1
Copy link
Owner

subeshb1 commented Jun 6, 2023

Thank you for the fix @pabin. I'll add this in the next release. I have some an issue to fix #42 which I'll plan to do during the weekends. Once that's done I'll release this fix

@subeshb1
Copy link
Owner

@pabin Would you mind linking the source where you found the dates?

The sources I've been following have 31 for Jestha and 32 for Ashar

Hamro Patro
https://english.hamropatro.com/calendar/2081/2
https://english.hamropatro.com/calendar/2081/3

Nepali Calendar
https://nepalicalendar.rat32.com/2081/jestha
https://nepalicalendar.rat32.com/2081/ashad

@pabin
Copy link
Contributor Author

pabin commented Jun 11, 2023

It was confusing to me as well since I also found 2 different dates in different calendars

Calendars with 32 Jestha and 31 Ashar:
https://nepalipatro.com.np/calendar/monthly/bs/2081/2
https://www.hamropatro.com/calendar/2081/2
https://www.ashesh.com.np/nepali-calendar/?year=2081&month=Jestha

I am considering nepalipatro as official here.

Let's wait and confirm the dates before merging.

@rajbinms
Copy link

Hey! Jumping in @subeshb1 @pabin has this been included in the release yet? I see dates for Falgun (30 to 29) and Chaitra (30 to 31) for the 2081 calendar.

@pabin
Copy link
Contributor Author

pabin commented Mar 3, 2024

hey @subeshb1 can you confirm now and review the PR please, I have also updated the total days for falgun and chaitra 2081 as the issue raised by @rajbinms also seems right

@subeshb1
Copy link
Owner

Thanks for jumping into this @pabin and @rajbinms. I'll merge and release the fix

@subeshb1 subeshb1 merged commit 9e74b54 into subeshb1:master Mar 27, 2024
subeshb1 pushed a commit that referenced this pull request Mar 27, 2024
…ra (#47)

* Fix month days for 2081 Jestha and Ashar

* fix date mismatch for 2081 falgun and chaitra
subeshb1 pushed a commit that referenced this pull request Mar 27, 2024
…ra (#47)

* Fix month days for 2081 Jestha and Ashar

* fix date mismatch for 2081 falgun and chaitra
subeshb1 pushed a commit that referenced this pull request Mar 27, 2024
…ra (#47)

* Fix month days for 2081 Jestha and Ashar

* fix date mismatch for 2081 falgun and chaitra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants