Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to support routing traffic to multiple services #3

Open
iamhopaul123 opened this issue Sep 20, 2019 · 7 comments
Open

Needs to support routing traffic to multiple services #3

iamhopaul123 opened this issue Sep 20, 2019 · 7 comments

Comments

@iamhopaul123
Copy link
Collaborator

Currently it can only route traffic to one virtual node (e.g., blue). However, if appmesh works normally it should also be able to route traffic to multiple virtual nodes. I tried to take a look at the code and found the Envoy containers are not attached to those services.

@subfuzion
Copy link
Owner

subfuzion commented Oct 2, 2019

It works exactly as it is supposed for this specific demo. The purpose of this demo is to use the console to enable App Mesh. The CDK deployment is used to deploy the app without App Mesh enabled and demonstrate that it is a working app, as you saw. Then, after using the console to enable App Mesh, you will be able to control traffic routing via App Mesh.

Please read the README or the Guide for more detail. Note that this demo was made to support this blog post. Thanks.

@subfuzion
Copy link
Owner

@iamhopaul123 I'll leave this issue open a bit longer in case you want to add more to this discussion. I'm also going to push an updated version that has the envoy placeholders commented out. Feel free to take a look, but I just tried and couldn't get ProxyConfiguration for the envoy containers working with L1 constructs (see this related issue).

Now that there is L2 support, however, it would be awesome if you want to help update this demo and submit a PR for it. Otherwise, I'll get to it when I have a some time and figure out how to be able to conditionally deploy so it's possible to still demo using the console to enable enable App Mesh as well as deploy a fully-working, mesh-enabled demo.

Thanks!

@iamhopaul123
Copy link
Collaborator Author

iamhopaul123 commented Oct 4, 2019

@subfuzion The proxyConfiguration is just about to be supported in CDK (sorry for the confusion, should appear in the next release), you can get the latest version of the CDK and try it out. Not sure if I have time to pick it up but I'll try. Take your time and I will keep watching this repo! Thanks for the reply!

@iamhopaul123
Copy link
Collaborator Author

iamhopaul123 commented Oct 4, 2019

Then, after using the console to enable App Mesh, you will be able to control traffic routing via App Mesh.

After proxyConfiguration get supported in CDK, is it possible to do all of that in CDK instead of using the console to enable the AppMesh? By the way, the blog is really well-written and very explicit and illustrative!

@iamhopaul123
Copy link
Collaborator Author

iamhopaul123 commented Oct 4, 2019

I think I will try to put up a PR translating into the L2 construct. (wait for the next CDK release for proxyConfiguration support and cloudmap exposed from ECS service so that it can be reused by app mesh L2 construct)

But I don't think I have enough understanding of this example and also the mechanism of the whole construct to realize the functionality that we can just use CDK to spin up the app mesh example without using the console.

@iamhopaul123
Copy link
Collaborator Author

BTW, to make it more public and impactful, can we migrate this repo to the CDK example. I believe this repo can help a lot of people who are struggling trying to spin up an example using CDK.

@subfuzion
Copy link
Owner

You definitely have permission to migrate the example. I'm not sure I've used best practices for canonical CDK Typescript code, so feel free to refactor as you think best. I'll be happy to help update docs, comments, and code based on any team recommendations. Glad if it helps anyone. CDK is great and definitely looking forward to proxyConfiguration support soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants