[Javascript] Arrow function arguments split across lines get wrong scope

[dsl101]

• Sublime Version: 3.2.2. Build 3211
• OS Version: Windows 10 64-bit

const oneLine = (p1, p2 = false) => {
  // etc
}

const oneLineDestructured = ({ p1, p2 = false }) => {
  // etc
}

const multiLine = (
  p1,
  p2 = false
) => {
  // etc
}

const multiLineDestructured = ({
  p1,
  p2 = false
}) => {
  // etc
}

Scope Hunter reports the function multiLine as source.js meta.binding.name.js variable.other.readwrite.js whereas oneLine is (correctly) source.js meta.function.declaration.js entity.name.function.js variable.other.readwrite.js. There are similar differences for all the other incorrectly highlighted elements. Let me know if it's useful to list them all.

[dsl101]

Also I found this similar issue in a different repo. I guess it's the same underlying problem (regex engine)? babel/babel-sublime#340

[rchl]

This is how it looks in ST4 build 4098:

Looks like the arguments look good now.
The variables don't get entity.name.function assigned though.

[Thom1729]

Yep, the current version of the JavaScript syntax fixes multiline arrow function. It relies on a new feature from ST4, so the fix cannot be backported to ST3.

The syntax still uses regexp lookaheads to scope function names in e.g. const f = () => {}, so in that example f won't get entity.name.function. I'd like to fix that, but I haven't worked out the best way to do it without blowing up the syntax definition size. See #2267.

[dsl101]

Fantastic—I will give ST4 a go. Many thanks.