[Ruby] More specific language constant scopes. #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathaxe
reviewed
Apr 14, 2021
jfcherng
previously approved these changes
Aug 17, 2021
deathaxe
previously approved these changes
Aug 17, 2021
|
@Ultra-Instinct-05 : Seems this needs some conflict resolving. We need some |
This commit assigns more specific scopes for boolean constants `true` & `false` from `constant.language` to `constant.language.boolean` & `nil` from `constant.language` to `constant.language.nil`.
Ultra-Instinct-05
dismissed stale reviews from deathaxe and jfcherng
via
cda32ee
Ultra-Instinct-05
force-pushed
the
specific_boolean_scopes
branch
from
ffe9bf8
to
cda32ee
Compare
jfcherng
approved these changes
Aug 18, 2021
|
@deathaxe I believe the conflict is resolved. Anyways, my first lesson in using |
|
Thanks. For larger PRs with many commits it can be easier to just merge the master branch into the PR branch. Otherwise you might need to resolve conflicts for every second commit during rebase. |
deathaxe
approved these changes
Aug 18, 2021
Ultra-Instinct-05
added a commit
to Sublime-Instincts/PackageDev
that referenced
this pull request
Sep 17, 2021
This commit adds `boolean` & `null` to the `constant.language` scope data. There were a few PR's regarding this. 1. sublimehq/Packages#2788 2. sublimehq/Packages#2785 3. sublimehq/Packages#2693
FichteFoll
pushed a commit
to SublimeText/PackageDev
that referenced
this pull request
Oct 7, 2021
This commit adds `boolean` & `null` to the `constant.language` scope data. There were a few PR's regarding this. 1. sublimehq/Packages#2788 2. sublimehq/Packages#2785 3. sublimehq/Packages#2693
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
This commit assigns more specific scopes for boolean constants `true` & `false` from `constant.language` to `constant.language.boolean` & `nil` from `constant.language` to `constant.language.nil`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assigns more specific scopes for boolean constants
true&falsefromconstant.languagetoconstant.language.boolean&nilfromconstant.languagetoconstant.language.nilconstant.language.null.Related PR's