[Lua] Add support for a few new syntax features introduced in Lua 5.4 and a couple improvements. #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua 5.4 introduces the concept of `const` & to-be-closed variables. 1. A `const` variable is a variable whos value cannot be changed after initialization. The syntax is a bit weird, though. 2. A to-be-closed variable behaves like a constant local variable, except that its value is closed whenever the variable goes out of scope, including normal block termination, exiting its block by break/goto/return, or exiting by an error. (The definition is taken from the official Lua docs https://www.lua.org/manual/5.4/manual.html#3.3.8)
Previously, the Lua syntax assigned a fourth level scope, true or false to identify between `true` & `false` (`false` again was wrongly scoped as `constant.language.boolean.true.lua`). I don't think it is really beneficial in having a 4th level scope to identify `true` vs `false` since most people will only want to have one color assigned to these boolean constants.
This commit adds the `meta.string` scope as per the scope naming guidelines and also `set`(s) into named string contexts instead of anonymous contexts to enhance debugging experience since it's currently not possible to know the state of anonymous contexts in the `show_scope_name` popup. All the tests have been updated.
Lua 5.4 adds a new API endpoint for the `coruotine` library i.e. `close`. This commit adds support for it.
This commit excludes snippets from being triggered in comments & strings since they are least likely to be used in comments & strings anyways.
FichteFoll
requested changes
Jan 14, 2021
I'd just like to apologize for this. |
deathaxe
reviewed
Jan 14, 2021
deathaxe
reviewed
Jan 14, 2021
deathaxe
reviewed
Jan 14, 2021
There was no need for apologizing at all. It's just something I noticed so decided to fix it. |
|
I believe I have addressed all of the review comments. Let me know if any of them are wrong or more corrections needs to be done. |
deathaxe
reviewed
Jan 17, 2021
deathaxe
reviewed
Jan 17, 2021
|
Thanks for the review. I have addressed both of the issues. |
FichteFoll
approved these changes
Jan 19, 2021
|
Thanks for your fixes here @Ultra-Instinct-05! As always, thank you for the reviews @FichteFoll and @deathaxe! |
Ultra-Instinct-05
added a commit
to Sublime-Instincts/PackageDev
that referenced
this pull request
Sep 17, 2021
This commit adds `boolean` & `null` to the `constant.language` scope data. There were a few PR's regarding this. 1. sublimehq/Packages#2788 2. sublimehq/Packages#2785 3. sublimehq/Packages#2693
FichteFoll
pushed a commit
to SublimeText/PackageDev
that referenced
this pull request
Oct 7, 2021
This commit adds `boolean` & `null` to the `constant.language` scope data. There were a few PR's regarding this. 1. sublimehq/Packages#2788 2. sublimehq/Packages#2785 3. sublimehq/Packages#2693
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
… and a couple improvements. (sublimehq#2693) * [Lua] Add support for `const` & to-be-closed variables. Lua 5.4 introduces the concept of `const` & to-be-closed variables. 1. A `const` variable is a variable whos value cannot be changed after initialization. The syntax is a bit weird, though. 2. A to-be-closed variable behaves like a constant local variable, except that its value is closed whenever the variable goes out of scope, including normal block termination, exiting its block by break/goto/return, or exiting by an error. (The definition is taken from the official Lua docs https://www.lua.org/manual/5.4/manual.html#3.3.8) * [Lua] Fix a mistake with scoping boolean language constant. Previously, the Lua syntax assigned a fourth level scope, true or false to identify between `true` & `false` (`false` again was wrongly scoped as `constant.language.boolean.true.lua`). I don't think it is really beneficial in having a 4th level scope to identify `true` vs `false` since most people will only want to have one color assigned to these boolean constants. * [Lua] Add `meta.string` scope and push|set to named contexts. This commit adds the `meta.string` scope as per the scope naming guidelines and also `set`(s) into named string contexts instead of anonymous contexts to enhance debugging experience since it's currently not possible to know the state of anonymous contexts in the `show_scope_name` popup. All the tests have been updated. * [Lua] Add support for `coroutine.close()`. Lua 5.4 adds a new API endpoint for the `coruotine` library i.e. `close`. This commit adds support for it. * [Lua] Exclude snippets from being triggered in comments & strings. This commit excludes snippets from being triggered in comments & strings since they are least likely to be used in comments & strings anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
truevsfalsei.e.constant.language.boolean.truefortrue&constant.language.boolean.trueforfalse(which is anyways wrong). Now, it reduces it to onlyconstant.language.booleansince there is very little value in having the previous scopes.meta.stringscope to strings to comply with the scope naming guidelines. I have also reworked the string contexts to actuallypushorsetinto named contexts instead of anonymous contexts for a better debugging experience (since it is currently not possible to distinguish between anonymous contexts in theshow_scope_namepopup).coroutine.close(). Support is added for that function.