Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSON] More detailed constants scopes #2785

Merged
merged 2 commits into from
Aug 17, 2021
Merged

[JSON] More detailed constants scopes #2785

merged 2 commits into from
Aug 17, 2021

Conversation

deathaxe
Copy link
Collaborator

No description provided.

@UltraInstinct05
Copy link
Contributor

Are there any real benefits of scoping true & false specifically up to using a 4th level scope (true vs false) ? I feel most users would never want different highlighting for true & false, so having constant.language.boolean.json would IMHO be sufficient for both. They are anyways scoped differently than null (if they wanted null to be of a different color).

@deathaxe
Copy link
Collaborator Author

deathaxe commented Apr 11, 2021 •
edited
Loading

Core syntax are different on that, yes. I just followed JavaScript here. It doesn't hurt neigher in performance nor implementation effort.

We also address if, else, ... in control keyword scopes, which is as useful or useless.

@UltraInstinct05 UltraInstinct05 mentioned this pull request Apr 12, 2021
Merged
@keith-hall keith-hall merged commit 2a9c739 into sublimehq:master Aug 17, 2021
@deathaxe deathaxe deleted the pr/json/update-constants branch August 28, 2021 08:49
UltraInstinct05 added a commit to Sublime-Instincts/PackageDev that referenced this pull request Sep 17, 2021
@UltraInstinct05
Add boolean & null to constant.language scope data.
29b4373 
This commit adds `boolean` & `null` to the `constant.language` scope
data. There were a few PR's regarding this.

1. sublimehq/Packages#2788
2. sublimehq/Packages#2785
3. sublimehq/Packages#2693
@UltraInstinct05 UltraInstinct05 mentioned this pull request Sep 17, 2021
Merged
FichteFoll pushed a commit to SublimeText/PackageDev that referenced this pull request Oct 7, 2021
@UltraInstinct05 @FichteFoll
Add boolean & null to constant.language scope data.
24d5389 
This commit adds `boolean` & `null` to the `constant.language` scope
data. There were a few PR's regarding this.

1. sublimehq/Packages#2788
2. sublimehq/Packages#2785
3. sublimehq/Packages#2693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcherng jfcherng jfcherng approved these changes

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deathaxe @UltraInstinct05 @jfcherng @keith-hall