-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest vscode-css-languageserver #13
Update to the latest vscode-css-languageserver #13
Conversation
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
- Change vscode-css/ into just language-server/ - Change compile-vscode-css-languageserver.sh into just compile-language-server.sh - Mention which language server is used in the README Signed-off-by: Jack Cherng <jfcherng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the build script should also clean up after itself - leave only the compiled version.
Something like I did in https://github.com/sublimelsp/LSP-eslint/blob/5ec75d65d1b235071a695d1b69829b883b07dcee/compile-server.sh
That sounds good to me. |
I kinda would wish to know from which to which commit we are updating now so that I could look through all the commits and check for any changes / potential new settings.... And I'm not saying you should tell me but I'm thinking about a potential solution for that like automatically storing commit hash on updating. Put I think that currently, we don't have that info (when pulling master). |
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Not sure what this means. Delete the downloaded file/dir? |
Yes, that's what I'm thinking. |
The simplest solution maybe move from "download the zipped tarball" to "clone the whole repo and then checkout" (and we don't have to clean up the downloaded repo, which can be reused next time). What do you think? |
I'm fine with using git but I'd still want to clean up I think. Otherwise, all those files are copied to the ST cache (when developing) and I'd like to avoid that. |
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@rchl Luckily, the commit hash is in the comment of the downloaded |
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
If you are gonna be merging this, please change the summary to say that it's about updating the server to the latest version as that is really the main reason for path "fix". |
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Sync with https://github.com/sublimelsp/LSP-eslint/blob/b9c8990b7fd2d4ac75b93f16c4bb107e0d0a0051/language-server/compile-language-server.sh#L40 Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
I tested this PR on Linux, and I got an error:
I will investigate further. |
Hmm, I deleted the cache LSP-css folder, and now it works. |
I also noticed this loader error when trying to update LSP-eslint. IMO it should be investigated because I feel like the upgrade mechanism is broken. |
I zipped the broken cache LSP-html folder that throws the error. I probably only need to find the differences between those folders to see what might be the cause. |
sublimelsp/LSP-css#13 Signed-off-by: Jack Cherng <jfcherng@gmail.com>
The server executable has been changed from
out/cssServerMain.ts
toout/node/cssServerMain.ts
in the upstream about 16 days ago.Other than that, I would also like to introduce another change to this (and other NPM-based
LSP-*
packages). That is, making this plugin less dependent on the server name (i.e.,vscode-css
,vscode-html
etc...).vscode-css/
,vscode-html/
etc... into justlanguage-server/
compile-vscode-css-languageserver.sh
into justcompile-language-server.sh
I think these changes should make it less work to create yet another NPM-based plugin by copy-paste. But I am free to revert this change, the major goal of this PR is to fix the changed upstream server path.