Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send hover request to all sessions that supports hoverProvider #1845

Merged
merged 10 commits into from
Sep 14, 2021

Conversation

predragnikolic
Copy link
Member

closes #sublimelsp/LSP-tailwindcss#19

Currently LSP sends only one hover request, which doesn't work nicely when there are multiple sessions running in a file.
LSP should send hover requests to all sessions that supports the hoverProvider.(like we do when requesting completions)

@predragnikolic
Copy link
Member Author

Note: There is one test that was failing even before this change:

======================================================================
ERROR: test_publish_diagnostics (test_server_notifications.ServerNotifications)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/predragnikolic/.config/sublime-text/Packages/UnitTesting/unittesting/core/py33/case.py", line 28, in _executeTestPart
    yield from deferred
  File "/home/predragnikolic/.config/sublime-text/Packages/LSP/tests/test_server_notifications.py", line 41, in test_publish_diagnostics
    yield lambda: len(self.view.get_regions("lspTESTds3")) > 0
TimeoutError: Condition not fulfilled within 4.00 seconds

----------------------------------------------------------------------
Ran 228 tests in 26.405s

plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
plugin/core/protocol.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
@predragnikolic predragnikolic force-pushed the feat/send-hover-request-to-multiple-servers branch from f4bb844 to efb0ad3 Compare September 14, 2021 19:08
@rwols rwols merged commit 0324d7f into main Sep 14, 2021
@rwols rwols deleted the feat/send-hover-request-to-multiple-servers branch September 14, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants