Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check capabilities against buffer when requesting code actions #2202

Merged
merged 5 commits into from
Feb 18, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Feb 17, 2023

On getting code actions, instead of checking Session capabilities, check against SessionBuffer so that we take into account dynamic capabilities that might have been registered (for specific document selector rather than globally).

Fixes #2201

@rchl rchl changed the title check capabilities against session buffer when requesting code actions check capabilities against buffer when requesting code actions Feb 18, 2023
@rchl rchl merged commit 0d11725 into main Feb 18, 2023
@rchl rchl deleted the fix/dynamic-code-actions branch February 18, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic registrations of source code actions are not supported in "on_save" trigger
3 participants