Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for OCaml and ReasonML #2386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smorimoto
Copy link

I plan to document instructions for Sublime on the OCaml-LSP side, but this change basically allows us to use OCaml-LSP as is.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@@ -344,10 +344,9 @@
},
"ocaml": {
"command": [
"ocaml-language-server",
"--stdio"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: this change would require some notice in the release notes.

@rchl
Copy link
Member

rchl commented Jan 3, 2024

I plan to document instructions for Sublime on the OCaml-LSP side, but this change basically allows us to use OCaml-LSP as is.

We should first see what ends up in their documentation so that we know what should we add here. Maybe they will not want too specific instructions and just general ones on how to start the server in which case we should document the rest here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants