Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health endpoint #35

Closed
cohix opened this issue May 12, 2021 · 5 comments · Fixed by #84
Closed

Health endpoint #35

cohix opened this issue May 12, 2021 · 5 comments · Fixed by #84
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cohix
Copy link
Contributor

cohix commented May 12, 2021

Atmo should expose a health endpoint that can be used to determine the health of Atmo. This can include whether or not a bundle has been successfully loaded and Atmo is available to serve requests.

@cohix cohix added enhancement New feature or request good first issue Good for newcomers labels May 12, 2021
@zhangwinning
Copy link
Contributor

zhangwinning commented Oct 19, 2021

~Hi @cohix

I'd like to work on this one. Can you assign me to it?

@cohix
Copy link
Contributor Author

cohix commented Oct 19, 2021

@zhangwinning sounds great! This will involve adding a handler to Atmo's router (which is generated by the coordinator - see atmo/coordinator/coordinator.go) that returns a 200ok response, indicating to the caller that Atmo is healthy. That handler should be mounted at the /health path.

@cohix
Copy link
Contributor Author

cohix commented Oct 19, 2021

Let me know if you need any assistance and myself or the team can help 🙂

@zhangwinning
Copy link
Contributor

~Hi @cohix, I see there are rust examples here, but I’m not familiar with rust, are there any js or ts examples?

@cohix
Copy link
Contributor Author

cohix commented Oct 21, 2021

@zhangwinning Yes! Atmo supports AssemblyScript (very similar to TypeScript), here's an example: https://github.com/suborbital/atmo/blob/main/example-project/as-graphql/src/lib.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants