Domain ID value not correctly recovered from chain data

[marc-aurele-besner]

User description

Domain ID value not correctly recovered from chain data

Causing every option to have the domain id 0

---

PR Type

Bug fix, Enhancement

---

Description

• Fixed the domainId assignment in the dropdown mapping function to use the index instead of an incorrect primitive value.
• Bumped the storage version to 2 for domain states.

---

Changes walkthrough 📝

	Relevant files
Bug fix	useDomainsData.ts Fix domain ID assignment in dropdown mapping function        explorer/src/hooks/useDomainsData.ts Fixed the domainId assignment to use the index instead of incorrect primitive value. Adjusted the mapping function to include the index parameter. +2/-2
Enhancement	domains.ts Update storage version to 2                                                            explorer/src/states/domains.ts Bumped the storage version to 2. +1/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[netlify]

✅ Deploy Preview for dev-astral ready!

Name	Link
🔨 Latest commit	4f01143
🔍 Latest deploy log	https://app.netlify.com/sites/dev-astral/deploys/668c35456c1cd40008ff15d5
😎 Deploy Preview	https://deploy-preview-694--dev-astral.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Bug: The change in useDomainsData.ts replaces the domainId assignment from a primitive value to an index. This might not be correct if the order of domains in domainRegistry is not guaranteed to match their actual IDs. This could lead to incorrect domain IDs being displayed or used.

[EmilFattakhov]

That was fast! Waiting for the test build to built.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Replace index-based domain identification with a stable, data-derived identifier Replace the use of index.toString() for domainId with a more reliable identifier from the domain object itself. Using the index as an identifier can lead to issues if the order of domains changes, which might not reflect the actual identity of the domain. explorer/src/hooks/useDomainsData.ts [22] -domainId: index.toString(), +domainId: domain[0].toPrimitive() as string, Suggestion importance[1-10]: 9 Why: Using the index as an identifier can lead to issues if the order of domains changes. A stable identifier from the domain object itself is more reliable and prevents potential bugs related to domain identity.	9
Best practice	Ensure data migration strategies are in place when updating storage version numbers When updating the version number in a state management setup, ensure that migration strategies or handlers are in place to manage the transition of stored data from the old version to the new version. This is crucial to prevent data loss or inconsistencies. explorer/src/states/domains.ts [31] -version: 2, +version: 2, // Ensure to implement migration strategies for version changes Suggestion importance[1-10]: 8 Why: Updating the version number without implementing migration strategies can lead to data loss or inconsistencies. This suggestion highlights a crucial best practice for state management.	8

[EmilFattakhov]

Something still seems a bit off @marc-aurele-besner

[EmilFattakhov]

Thanks Marc, seem to work well!