Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Support? #18

Closed
shama opened this issue Mar 2, 2016 · 3 comments · Fixed by #19
Closed

SVG Support? #18

shama opened this issue Mar 2, 2016 · 3 comments · Fixed by #19

Comments

@shama
Copy link
Member

shama commented Mar 2, 2016

Would you be open to a PR adding SVG self closing tags? Or a PR that exposes the self closing tags so one could supply their own?

Such as:

var hyperx = require('hyperx')
var hx = hyperx(function (tag, props, children) {
  /* ... turn into thing ... */
}, {
  selfClosingTags: ['circle', /* ... */]
})

var circle = hx`<svg viewBox="0 0 100 100">
  <circle r="${r}" />
</svg>`

Here is a good list of svg elements. Thanks!

@yoshuawuyts
Copy link
Member

I'm +1 on having SVG support land; not particularly in favor of adding custom tag declarations. Happy to review any PR that comes in! 😁

@ghost
Copy link

ghost commented Mar 2, 2016

automatic svg support would be great

@shama
Copy link
Member Author

shama commented Mar 2, 2016

Cool! I'll work on a PR using svg-tags for the list of supported tags.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants