New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the main test harness #170

Merged
merged 2 commits into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@TehShrike
Contributor

TehShrike commented Aug 8, 2015

Allows reporting failed/succeeded tests to SauceLabs/BrowserStack.

Fixes #148

This fix was even simpler than I'd imagined, so I'm opening this pull request instead of publishing the fork right away.

Expose the main harness's results object
Allows reporting failed/succeeded tests to SauceLabs/BrowserStack.

Fixes #148

@TehShrike TehShrike changed the title from Expose the main harness's results object to Expose the main harness's results object: a cool pull request that should totally get merged and deployed soon in the interest of making the awesome tape library even more awesomer Aug 11, 2015

index.js Outdated
@@ -35,9 +35,13 @@ exports = module.exports = (function () {
}
return harness.createStream(opts);
};


lazyLoad.results = function () {

This comment has been minimized.

@Raynos

Raynos Aug 11, 2015

Collaborator

this is not general enough; let's just lazyLoad.getHarness = getHarness;

@Raynos

This comment has been minimized.

Collaborator

Raynos commented Aug 11, 2015

Will merge after feedback addressed.

@TehShrike

This comment has been minimized.

Contributor

TehShrike commented Aug 11, 2015

Sounds good to me! New commit pushed up.

@TehShrike TehShrike changed the title from Expose the main harness's results object: a cool pull request that should totally get merged and deployed soon in the interest of making the awesome tape library even more awesomer to Expose the main test harness Aug 11, 2015

Raynos added a commit that referenced this pull request Aug 11, 2015

Merge pull request #170 from TehShrike/master
Expose the main test harness

@Raynos Raynos merged commit d26e522 into substack:master Aug 11, 2015

@Raynos

This comment has been minimized.

Collaborator

Raynos commented Aug 12, 2015

Published v4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment