New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias 'notDeepEquals' to 'notDeepEqual' function #411

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@bambusekd
Copy link
Contributor

bambusekd commented Nov 22, 2017

This is just a small cosmetic update, but in my opinion, if there is alias deepEquals (with the s at the end) for function deepEqual, there should also be alias notDeepEquals for notDeepEqual function. Not that there is already not enought of aliases for that function, but I would add it there just to keep consistency.

@ljharb

ljharb approved these changes Jan 9, 2019

Copy link
Collaborator

ljharb left a comment

Although the plural form isn't on assert, we have the plural forms of some others, so we should add this one too.

@ljharb ljharb added the enhancement label Jan 9, 2019

@ljharb ljharb force-pushed the bambusekd:master branch from 57f7809 to 35844e6 Jan 9, 2019

@ljharb ljharb merged commit 35844e6 into substack:master Jan 9, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment