To avoid side-effects, clone objects array on Data.Collection creation.

substance · May 2, 2012 · 79aee27 · 79aee27
1 parent 91e90c3
commit 79aee27
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/data.js b/data.js
@@ -457,7 +457,7 @@
   // Creates a Data.Collection using a Data.Type, and an array of Data.Objects
   Data.Collection.create = function(type, objects) {
     var c = new Data.Collection({type: type, objects: []});
-    c.objects = objects;
+    c.objects = _.clone(objects);
     c.length = objects.length;
 
     // Register keys for fast lookup