Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Add toolchain file #92

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Add toolchain file #92

merged 3 commits into from
Oct 10, 2020

Conversation

danforbes
Copy link
Contributor

Add a toolchain file to avoid bugs related to instability in nightly builds.

Closes #76
Relates to #90
Closes #91

@danforbes danforbes marked this pull request as draft October 9, 2020 13:59
@danforbes
Copy link
Contributor Author

This was the result of running cargo check with the new toolchain file? Is there some other set up we need to specify in order to get this working?

      Finished dev [unoptimized + debuginfo] target(s) in 1m 28s
       Running `/home/parity/Code/node-template/target/debug/wbuild-runner/node-template-runtime13439624246709566360/target/x86_64-unknown-linux-gnu/debug/wasm-build-runner-impl`
  Rust WASM toolchain not installed, please install it!
warning: build failed, waiting for other jobs to finish...
error: build failed

@adoerr
Copy link

adoerr commented Oct 10, 2020

Are you sure, you have installed the WASM toolchain for the specific nightly version you are using in the toolchain file. I'm using a toolchain file and it works just fine.

@danforbes danforbes mentioned this pull request Oct 10, 2020
Merged
@danforbes danforbes marked this pull request as ready for review October 10, 2020 14:59
@danforbes
Copy link
Contributor Author

This should be rounded out with substrate-developer-hub/substrate-developer-hub.github.io#712

@danforbes danforbes requested a review from bkchr October 10, 2020 14:59
@wheresaddie
Copy link
Contributor

I had no issues as long as I assigned the WASM to the nightly match @danforbes please advise if you are still having issues

@danforbes
Copy link
Contributor Author

Yep, that's definitely the missing step...hopefully I have it documented the best way, but I'm more than happy to accept suggestions.

wheresaddie
wheresaddie approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@wheresaddie wheresaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add a code comment to verify match with WASM to nightly rust if there are any issues or QA you see popping up-- otherwise looks good. thanks D.

bkchr
bkchr reviewed Oct 10, 2020
View reviewed changes
README.md Outdated
### Manual Setup

Find manual setup instructions at the
Setup instructions can be found at the
[Substrate Developer Hub](https://substrate.dev/docs/en/knowledgebase/getting-started/#manual-installation).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no manual-installation sub-heading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the subheading 👍

@danforbes danforbes merged commit 5769470 into master Oct 10, 2020
@danforbes danforbes deleted the df/chore/toolchain branch October 10, 2020 15:45
This was referenced Oct 14, 2020
Closed
Closed
marc0olo pushed a commit to 51nodes/substrate-node-template that referenced this pull request Feb 12, 2021
Add toolchain file (substrate-developer-hub#92)
03198dc 
* Add toolchain file

* Remove reference to script that uses latest nightly

* Remove link to nonexistent subheading
F3Joule pushed a commit to F3Joule/dappforce-subsocial-node that referenced this pull request Oct 12, 2021
@siman
Merge pull request substrate-developer-hub#92 from samchuk-vlad/vs-fi…
4170186 
…x-test

Add tests for permissions and transfer ownership
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@wheresaddie wheresaddie wheresaddie approved these changes

@folsen folsen Awaiting requested review from folsen

@gnunicorn gnunicorn Awaiting requested review from gnunicorn

@jimmychu0807 jimmychu0807 Awaiting requested review from jimmychu0807

@riusricardo riusricardo Awaiting requested review from riusricardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danforbes @adoerr @wheresaddie @bkchr