Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Adjust startercode branch to be in line with master #79

Open
wants to merge 66 commits into
base: startercode
Choose a base branch
from

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Nov 5, 2020

People were having trouble compiling the startercode branch of the utxo-workshop here: paritytech/substrate#7256
Adjusted the branch to be in line with the master branch.

JoshOrndorff and others added 15 commits April 20, 2020 10:10
…on-keys

Remove session keys from runtimes
* Sketch initial testing

* sketch some integration testing

* fix indetn

* Fix more indent

* strip overly-entheusiastic attempt at Full UX test
* Bump dependencies

* runtime compiles

* runtime tests pass

* Node compiles

* Remove no-longer-correct weight type
* runtime compiles

* Sha3 mining algo compiles

* fix chain spec

* clean command

* Try to figure out concrete type of `PowBlockImport`.

* Update README.md

text minor reworks

* Compiles

* prune commented code

* Prune init script and improve readme

* prune unused MinimalSha3Algorithm

* Fix tests

Co-authored-by: Addie Wagenknecht <addie@nortd.com>
* add test that seems to spend non-existing tokens

* add pub key workaround

* tests should fail when bad things happen

* Another test that should be failing.

* fix the bug

* Update runtime/src/utxo.rs

Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>

* Update runtime/src/utxo.rs

Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
@JoshOrndorff
Copy link
Contributor

If you're bringing the video / workshop part of this up to speed, I highly recommend referencing a tag in the new videa rather than a branch like last time.

The reason is that when this PR gets merged the old video will talk about a branch that no longer points where it pointed when the video was recorded.

@apopiak
Copy link
Contributor Author

apopiak commented Nov 5, 2020

Well I was just trying to bring this branch to an equivalent state to master so that people would be able to compile it again and work from it.
I'm not planning on updating the video for now.
Would actually really appreciate if @nczhu could chime in on how to proceed :-)

@apopiak apopiak requested a review from nczhu November 5, 2020 15:57
@apopiak apopiak marked this pull request as ready for review November 5, 2020 15:59
@fiexer
Copy link

fiexer commented Nov 15, 2020

Any updates on adjusting the branch to be in line with the master branch?
Thanks!

…code

Update startercode branch to v2.0.0
@zhangyouxin
Copy link

Hello, thanks for creating this branch
but I met some issue here

OS: mac Big Sur 11.2.3
rustc: rustc 1.53.0 (53cb7b09b 2021-06-17)
cargo: cargo 1.53.0 (4369396ce 2021-04-27)

when I run cargo check on this branch, I got following error:

Checking primitive-types v0.7.2
error[E0282]: type annotations needed
--> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9
|
541 | let accuracy = P::ACCURACY.saturated_into();
| ^^^^^^^^ consider giving accuracy a type
...
1595 | / implement_fixed!(
1596 | | FixedI64,
1597 | | test_fixed_i64,
1598 | | i64,
... |
1601 | | "Fixed Point 64 bits signed, range = [-9223372036.854775808, 9223372036.854775807]",
1602 | | );
| |__- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed
--> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9
|
541 | let accuracy = P::ACCURACY.saturated_into();
| ^^^^^^^^ consider giving accuracy a type
...
1604 | / implement_fixed!(
1605 | | FixedI128,
1606 | | test_fixed_i128,
1607 | | i128,
... |
1611 | | [-170141183460469231731.687303715884105728, 170141183460469231731.687303715884105727]_",
1612 | | );
| |__- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed
--> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9
|
541 | let accuracy = P::ACCURACY.saturated_into();
| ^^^^^^^^ consider giving accuracy a type
...
1614 | / implement_fixed!(
1615 | | FixedU128,
1616 | | test_fixed_u128,
1617 | | u128,
... |
1621 | | [0.000000000000000000, 340282366920938463463.374607431768211455]_",
1622 | | );
| |__- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 3 previous errors

For more information about this error, try rustc --explain E0282.
error: could not compile sp-arithmetic

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants