Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make a non-italic versions? #15

Closed
dinhquochan opened this issue Apr 21, 2021 · 3 comments
Closed

[Feature Request] Make a non-italic versions? #15

dinhquochan opened this issue Apr 21, 2021 · 3 comments

Comments

@dinhquochan
Copy link

Dear,

I really like Monokai Pro, but it's seem use many italic fonts. So, I can switch them manually but can you create another versions for it?

Thanks.

@espositocode
Copy link
Collaborator

Yea this has bothered me too. I originally copied the color scheme from Material plugin and they made liberal use of italics, which is frustrating especially if your not using a font like Operator Mono which is designed for beautiful monospaced italics. However, a lot of people like them and I don't want to remove this feature for everybody. I also don't want to have tons of themes to choose from supporting every possible preference.

I need to think of an elegant solution that either makes this configurable from a settings panel or maybe allow users to pass in variables to the build script.

For now you can disable the italics manually for each field, but I will think about this.

@dinhquochan
Copy link
Author

I need to think of an elegant solution that either makes this configurable from a settings panel or maybe allow users to pass in variables to the build script.

It's awesome. Thank @jontaydev

@espositocode
Copy link
Collaborator

espositocode commented Apr 28, 2021

I looked into this and couldn't figure out how to make this changeable from a settings panel. For now, I decided to just add separate color schemes for non-italic versions. I'm not super happy with this - but having a non-italic option was important for me and I know its a divisive issue for even the official theme: monokai-pro/vscode#27

Variations are selected from the Editor/Color Scheme settings panel. (Variations will not appear in the main theme selection under the Appearance panel.)

Screen Shot 2021-04-27 at 5 46 55 PM

Uploaded the new version to JetBrains and will be available in a few days. I'm also going to keep researching other solutions to this, so would be happy to hear any ideas if anybody comes across this issue.

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants