Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI Compatibility #44

Open
kawazoe opened this issue Nov 18, 2022 · 4 comments
Open

New UI Compatibility #44

kawazoe opened this issue Nov 18, 2022 · 4 comments

Comments

@kawazoe
Copy link

kawazoe commented Nov 18, 2022

I was testing the New UI beta and noticed that a lot of tool windows from this theme do not have the correct background. I haven't seen this issue with the other themes I've tested (including nightfall and One Dark) so I thought I'd flag it even though it's still in beta.

Actual: Affected tool windows (in WebStorm)

  • Project (modes: Project)
  • NPM
  • Structure
  • Bookmarks
  • Notifications
  • Services
  • TODOs
  • Problems
  • Search Everywhere Popup

image

All of them use the default background color #2D2A2E instead of the list background color #221F22 making the content a bit difficult to read. I've also notice this happening in some plugins like the TeamCity tool window, suggesting that there might be some global default to set all of them correctly.

Expected: Tool windows that appear to behave correctly (in WebStorm)

  • Project (modes: Project Files, Tests, Open Files, All Changed Files, Scratches and Consoles)[1]
  • Commit
  • Pull Request
  • Settings Window
  • Run/Debug Configurations Window

image

[1] Small note. After a restart, this stopped working for a reason. Now all modes behave the same (badly). Weird....

@kawazoe
Copy link
Author

kawazoe commented Nov 19, 2022

Another issue I have noticed is that heading texts are very dim which can be awkward when they are used for buttons like on the various tabs displayed in the IDE (see my previous screenshots) as they look like they are disabled buttons.

@espositocode
Copy link
Collaborator

Late to respond, but thanks for putting this on my radar. I will look into this.

@albyrock87
Copy link

The same problem affects also the other variants like "Spectrum".
DataGrip has the same issue.
Thanks for this great theme!

@espositocode espositocode pinned this issue Dec 15, 2022
@HikaruHokkyokusei
Copy link
Contributor

If I remember correctly, I have put a fix for this in the existing pending PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants