Settings 4.5th 201025 (partially merged) #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Policy: No unnecessary changes on comments or words - Disabled functional tests against no previous releases * feature_backwards_compatibility.py * wallet_upgradewallet.py * mempool_compatibility.py - CI: * Travis * Cirrus * Gitian
- Ports: * Main: 8333/8332 -> 34230/34229 * Testnet: 18333/18332 -> 44230/44229 * Regtest: 18444/18443 -> 45340/45339 * Signet: 38333/38332 -> 54230/54229 - Fixed tests: * src/test/addrman_tests.cpp * test/functional/p2p_addr_relay.py - CI: * Travis * Cirrus * Gitian
- Disallow fPowNoRetargeting on testnet - Remove: Special difficulty rule for testnet - Disabled Tests: * src/test/fuzz/pow.cpp * src/test/miner_tests.cpp Reference: - zcash: https://github.com/zcash/zcash/blob/4c90270469e32cbf3459ec2fd25d46a089bd5c58/src/pow.cpp - bitcoin: https://github.com/bitcoin/bitcoin/blob/eb7daf4d600eeb631427c018a984a77a34aca66e/src/pow.cpp
- Add module: https://www.openwall.com/yespower/yespower-1.0.1.tar.gz - Fix lint: regexp exclude prefix: src/crypto/yespower-1.0.1
Reference: - sugarchain: sugarchain-project/sugarchain#22 by Volbil - resistance: * ResistancePlatform/resistance-core@a73d694 by solardiz * ResistancePlatform/resistance-core@3c80dac * ResistancePlatform/resistance-core@20c7ba3...3c80dac - util: * replace fprintf with tfm::format: bitcoin/bitcoin@fac03ec * function "bool ProcessNewBlock(...)" moved to "bool ChainstateManager::ProcessNewBlock(...)" in validation.cpp * use "m_blockman.m_block_index" rather than "mapBlockIndex" in validation.cpp Disabled Tests: - no fuzz on `00_setup_env_native_fuzz_with_valgrind` - no unit tests, no functional tests on Arm64 - "--disable-shared" for yespower on Win64 - no extended, no previous releases on x86_64 Linux Disabled Functional Tests (29) in `test/functional/test_runner.py`: CI: - Travis * remove YESPOWER_OPTION against conflict with MSAN_FLAGS - Cirrus - Gitian Windows Build for all (yespower): use "--disable-shared", skip DLL in gitian
- Changes:
* nPowTargetSpacing = 5
* nSubsidy = 42.94967296
* MAX_MONEY = 1073741824
* nSubsidyHalvingInterval = 12500000
- TODO: policy/feerate.cpp:16:34: runtime error: signed integer overflow: 107374182400000000 * 1000 cannot be represented in type 'long'
* MAX_FUTURE_BLOCK_TIME = 60
* DEFAULT_HTTP_WORKQUEUE=128
* STALE_CHECK_INTERVAL = 5
* EXTRA_PEER_CHECK_INTERVAL = 3
* MINIMUM_CONNECT_TIME = 15
* DEFAULT_MAX_TIME_ADJUSTMENT = 70
* pchMessageStart
- Disabled Tests:
* src/test/amount_tests.cpp
* src/test/fuzz/fee_rate.cpp
* src/test/fuzz/fees.cpp
* src/test/fuzz/psbt.cpp
* Many in test/functional/test_runner.py
- Fixed Tests:
* src/test/pow_tests.cpp
* src/test/timedata_tests.cpp
* src/test/validation_tests.cpp
* src/timedata.cpp
* src/wallet/test/wallet_tests.cpp
* test/functional/feature_loadblock.py
* test/functional/test_framework/p2p.py
- TODO: Signet MAGIC_BYTES
- Changes: * PUBKEY_ADDRESS * SCRIPT_ADDRESS * bech32_hrp - Fixed Tests: * src/qt/test/uritests.cpp * src/qt/test/wallettests.cpp * src/test/key_tests.cpp * src/test/rpc_tests.cpp * src/test/util/wallet.cpp * src/test/util_tests.cpp * test/functional/test_framework/address.py * test/functional/test_framework/test_node.py - Fixed Test Data: * src/test/data/key_io_invalid.json * src/test/data/key_io_valid.json * Many in test/util/data/ - Disabled Tests: * Many in test/functional/test_runner.py
- Changes: * nMinimumChainWork, defaultAssumeValid, chainTxData * m_assumed_blockchain_size, m_assumed_chain_state_size * vSeeds - CI: * Travis: No unit tests on MSan
This reverts commit f72c0f2.
!Fix: During IBD, do not download additional block headers, against too much traffic !Fix: During IBD, do not disconnect peers for the reason, "Potential stale tip detected" ::ChainstateActive().IsInitialBlockDownload()
This reverts commit 5b6fe88.
decryp2kanon
force-pushed
the
settings_4th_201025
branch
from
63a739a
to
7e3a3fe
Compare
…stale tip detected"
!TODO: should recheck later
|
|
- feature_uacomment.py - feature_asmap.py
decryp2kanon
force-pushed
the
settings_4th_201025
branch
from
d49dedc
to
829c52b
Compare
…settings" This reverts commit 9fe0eb1.
decryp2kanon
force-pushed
the
settings_4th_201025
branch
from
ec27102
to
745926a
Compare
decryp2kanon
commented
Oct 31, 2020
| @@ -3640,7 +3654,8 @@ bool BlockManager::AcceptBlockHeader(const CBlockHeader& block, BlockValidationS | |||
| return true; | |||
| } | |||
|
|
|||
| if (!CheckBlockHeader(block, state, chainparams.GetConsensus())) { | |||
| // During download headers, do not CheckBlockHeader for performance reason // See https://github.com/sugarchain-project/sugarchain/pull/122 | |||
| if (!::ChainstateActive().IsInitialBlockDownload() && !CheckBlockHeader(block, state, chainparams.GetConsensus())) { | |||
There was a problem hiding this comment.
assume this made fuzzing failure
https://travis-ci.org/github/sugarchain-project/yumekawa/builds/740341268#L3642
decryp2kanon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF
TODO
NETWORK
UI
Splash Screen
removeUI width/height
UI adding Seconds field
date.toString("hh:mm")Delaying Updating Balance (workaround)
Icon
Release Notes
FEATURE
-prunedebuglogfilebool fPruneDebugLog = false;SKIP
IBD
Potential, connect() to %s failedconsensusParams.nPowTargetSpacing * 120YESPOWER
NETWORK