Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and copyedits to README for Samples #1468

Closed
pikurasa opened this issue Oct 24, 2018 · 4 comments
Closed

Update and copyedits to README for Samples #1468

pikurasa opened this issue Oct 24, 2018 · 4 comments
Labels
Good first issue Issue-Enhancement

Comments

@pikurasa
Copy link
Collaborator

Good first issue!

NOTE: Recommended that you try the instructions once before trying.

Start from where we left off at https://github.com/sugarlabs/musicblocks/pull/1458/files/5065964e977ce21e75fc5a67287d425f90544c1e..eff8d4bdd22986857ae0b66faca7a98ce734d28b to improve the instructions for adding a sample sound to MB.
@pikurasa
Copy link
Collaborator Author

pikurasa commented Nov 7, 2018

Please also add:
[ ] only one pitch (no melodic movement)
[ ] after tuning the synth, use your ear and ask yourself "does the pitch sound the similar" (often, software tools cannot accurately identify the fundamental pitch -- trust your ears! Train your ears!)
[ ] steady pitch
[ ] longer tones are best

@manangoel99
Copy link

Can I take up this issue?

@rhl-bthr
Copy link

Please note there is no need to ask permission to work on an issue. See our guide to contributing

@manangoel99
Copy link

Could you please elaborate a little on what needs to be done?

@navyasri1 navyasri1 mentioned this issue Mar 13, 2019
Merged
walterbender pushed a commit that referenced this issue Mar 17, 2019
@navyasri1 @walterbender
Updated ReadMe of samples #1468 (#1750)
2506883 
* Edited Readme

* Updated Readme

* Updated Readme

* Updated Readme

* Updated Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Issue-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@walterbender @pikurasa @rhl-bthr @manangoel99