Updated ReadMe of samples #1468 #1750
Conversation
sounds/samples/README.md
Outdated
| @@ -3,6 +3,8 @@ How to add a new sample sound | |||
|
|
|||
| * Find a sample under a free/libre open-source (FOSS) license. | |||
|
|
|||
| * The sample has to have only one note (pitch) through out the audio and the volume has to be 50 . The longer the sample, the better it is. | |||
There was a problem hiding this comment.
I don't understand what you are saying here. Also, a long sample length is not always appropriate or better.
There was a problem hiding this comment.
I agree with his first three points, but not the last one. It really depends on the instrument. Maybe you can use the "check box" approach he used in the comment. I think it is clearer than the wording you used.
There was a problem hiding this comment.
I will use checkbox and remove the longer tones part for now.
sounds/samples/README.md
Outdated
|
|
||
| * [ ] Only one pitch (no melodic movement) | ||
|
|
||
| * [ ] After tuning the synth, use your ear and ask yourself "does this pitch sound the similar" (Audacity can be used to some extent for fundamental pitch)[Audacity](https://manual.audacityteam.org/man/change_pitch.html). |
There was a problem hiding this comment.
Can you please clarify: "does this pitch sound the similar"? I think you don't need "the". But, similar to what?
There was a problem hiding this comment.
It means constant frequency throughout the sample. In issue #1485 he mentioned about English Horn and vibraphone playing two notes.
There was a problem hiding this comment.
So perhaps you should say: "does this sound have a constant frequency throughout the sample?"
No description provided.